Create rule S7161: Tableau secrets should not be disclosed #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
loris-s-sonarsource
changed the title
jamie-anderson-sonarsource
requested changes
Nov 15, 2024
rules/S7161/secrets/rule.adoc
Outdated
Comment on lines
10
to
17
| Tableau secrets scopes depend on the type of secret. From the most impactful to | ||
| the least: | ||
|
|
||
| 1. Account passwords | ||
| 2. Personal access tokens (PAT) | ||
| 3. "Credentials token", received after a SignIn request | ||
|
|
||
| Their scopes vary in terms of lifetime, access, and impact. |
There was a problem hiding this comment.
It feels like the word "impact" appears very frequently here, especially given that it's also in the section title. However, it doesn't negatively affect the meaning of the text so it's not something that needs to be changed.
There was a problem hiding this comment.
I will make it a little more specific
Co-authored-by: Jamie Anderson <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: