Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7155: CircleCI secrets should not be disclosed (APPSEC-2239) #4490

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource changed the title Create rule S7155 Create rule S7155: CircleCi secrets should not be disclosed (APPSEC-2239) Nov 12, 2024
@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource changed the title Create rule S7155: CircleCi secrets should not be disclosed (APPSEC-2239) Create rule S7155: CircleCI secrets should not be disclosed (APPSEC-2239) Nov 12, 2024
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource marked this pull request as ready for review November 13, 2024 15:32
@hendrik-buchwald-sonarsource
Copy link
Contributor

@sebastien-andrivet-sonarsource the validate_rules check fails but I haven't found out yet why. This is the error message:

Rule secrets:S7155 has a "Code examples" subsection with an unallowed name: "Reducing the permission scope per secret"
Validation failed due to 1 errors
Aborted!
ERROR: There are invalid rule descriptions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use the same name as the provider for the secret to make it easy to understand for the user what we are referring to.

Also, something is breaking the rule check.

rules/S7155/secrets/metadata.json Outdated Show resolved Hide resolved
rules/S7155/secrets/rule.adoc Outdated Show resolved Hide resolved
rules/S7155/secrets/rule.adoc Outdated Show resolved Hide resolved
rules/S7155/secrets/rule.adoc Outdated Show resolved Hide resolved
@sebastien-andrivet-sonarsource
Copy link
Contributor

I applied the suggestion and fixed the failing check.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource merged commit 9f98b3b into master Nov 14, 2024
10 of 11 checks passed
@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource deleted the rule/add-RSPEC-S7155 branch November 14, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants