Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-590 Create rule S7133: Locks should be released within the same method #4449

Merged
merged 9 commits into from
Nov 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 29, 2024

You can preview this rule here (updated a few minutes after each push).

https://sonarsource.atlassian.net/browse/NET-590

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Create rule S7133 Create rule S7133: Locks should be released within the same method Oct 29, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Create rule S7133: Locks should be released within the same method NET-590 Create rule S7133: Locks should be released within the same method Oct 31, 2024
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1

rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks, there's also one unresolved thread above

rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7133/csharp/rule.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last reorder above

Copy link

sonarqube-next bot commented Nov 1, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Nov 1, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review November 15, 2024 15:21
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 21cc340 into master Nov 15, 2024
9 of 10 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the rule/add-RSPEC-S7133 branch November 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants