Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-589 Create rule S7131: You should not release a write lock when a read lock has been acquired and vice versa #4433

Merged
merged 14 commits into from
Nov 14, 2024
Merged

NET-589 Create rule S7131: You should not release a write lock when a read lock has been acquired and vice versa #4433

merged 14 commits into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2024 •
edited by mary-georgiou-sonarsource
Loading

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Create rule S7131 Create rule S7131: You should not release a write lock when a read lock has been acquired Oct 24, 2024
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round.

rules/S7131/csharp/metadata.json Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Show resolved Hide resolved
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Create rule S7131: You should not release a write lock when a read lock has been acquired NET-589 Create rule S7131: You should not release a write lock when a read lock has been acquired Oct 30, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title NET-589 Create rule S7131: You should not release a write lock when a read lock has been acquired NET-589 Create rule S7131: You should not release a write lock when a read lock has been acquired and vice versa Oct 30, 2024
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just polishing

rules/S7131/csharp/metadata.json Outdated Show resolved Hide resolved
rules/S7131/csharp/metadata.json Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round. There's also one unresolve thread above

rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S7131/message.adoc Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with final polishing

rules/S7131/csharp/rule.adoc Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 1, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 1, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as ready for review November 14, 2024 15:43
@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 423514e into master Nov 14, 2024
8 of 10 checks passed
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the rule/add-RSPEC-S7131 branch November 14, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource left review comments

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-mikula-sonarsource @mary-georgiou-sonarsource