Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S6868: Make S6868 a Security Hotspot #4340

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Modify rule S6868: Make S6868 a Security Hotspot #4340

merged 1 commit into from
Dec 3, 2024

Conversation

daniel-teuchert-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@daniel-teuchert-sonarsource daniel-teuchert-sonarsource changed the title Modify Rule S6868: Make S6868 a Security Hotspot Modify rule S6868: Make S6868 a Security Hotspot Sep 27, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

loris-s-sonarsource
loris-s-sonarsource approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor: Moving a sentence from a place to another

rules/S6868/kubernetes/rule.adoc Outdated
@@ -55,27 +45,14 @@ rules:
verbs: ["get"]
----

=== How does this work?

The `exec` permissions are set by allowing the `create` verb for the `pods/exec` resource. Removing this permission will prevent users and services from executing arbitrary commands within containers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is lonely here, I suggest adding moving it from here to the "recommended secure practices"

@jonas-wielage-sonarsource jonas-wielage-sonarsource force-pushed the appsec-2127/make-s6868-a-security-hotspot branch from 406f9b9 to 9d50a77 Compare December 3, 2024 14:45
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 3, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 3, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

jonas-wielage-sonarsource
jonas-wielage-sonarsource reviewed Dec 3, 2024
View reviewed changes
rules/S6868/kubernetes/description.adoc
Comment on lines +14 to +15
The `exec` permissions are set by allowing the `create` verb for the `pods/exec` resource.
Removing this permission will prevent users and services from executing arbitrary commands within containers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added here according to Loris suggestions

@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit 485be38 into master Dec 3, 2024
10 checks passed
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the appsec-2127/make-s6868-a-security-hotspot branch December 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-wielage-sonarsource jonas-wielage-sonarsource jonas-wielage-sonarsource left review comments

@loris-s-sonarsource loris-s-sonarsource loris-s-sonarsource approved these changes

Assignees
No one assigned
Labels
appsec iac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-teuchert-sonarsource @loris-s-sonarsource @jonas-wielage-sonarsource