Modify rule S6864: Add examples for LimitRange #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertrr
force-pushed
the
peter.trifanov/s6864-add-x-file-example
branch
from
81c17fc to
8c48735
Compare
mstachniuk
approved these changes
Jun 26, 2024
rules/S6864/kubernetes/rule.adoc
Outdated
| @@ -39,7 +39,7 @@ node failure. | |||
|
|
|||
| === Code examples | |||
|
|
|||
| To avoid potential issues specify a memory limit for each container. | |||
| To avoid potential issues either specify a memory limit for each container or create a resource of kind `LimitRange` that sets a default memory limit for all containers in a namespace. | |||
There was a problem hiding this comment.
Suggested change
| To avoid potential issues either specify a memory limit for each container or create a resource of kind `LimitRange` that sets a default memory limit for all containers in a namespace. | |
| To avoid potential issues either specify a memory limit for each container or create a resource of kind `LimitRange` that sets a default memory limit for all containers/pods in a namespace. |
There was a problem hiding this comment.
Limits are specified for each container in the pod specification, so I chose this wording
There was a problem hiding this comment.
Rephrased a bit to mention pod specifications
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
A dedicated reviewer checked the rule description successfully for: