Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6877: SequencedCollection reversed view should be used instead of reverse copy #3562

Merged
merged 8 commits into from
Feb 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the java label Jan 30, 2024
@kaufco kaufco changed the title Create rule S6877 Create rule S6877: SequencedCollection reversed view should be used instead of Collections.reverse for read-only lists Jan 30, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Just some small rewordings and the re-format of the links

rules/S6877/java/metadata.json Outdated Show resolved Hide resolved
rules/S6877/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6877/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6877/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6877/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6877/java/rule.adoc Outdated Show resolved Hide resolved
kaufco and others added 8 commits January 30, 2024 17:02
…instead of Collections.reverse for read-only lists
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
@kaufco kaufco force-pushed the rule/add-RSPEC-S6877 branch from a30c405 to d8c1176 Compare January 30, 2024 16:02
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kaufco kaufco marked this pull request as ready for review February 1, 2024 08:28
@kaufco kaufco merged commit e8879ca into master Feb 1, 2024
10 of 11 checks passed
@kaufco kaufco deleted the rule/add-RSPEC-S6877 branch February 1, 2024 08:29
@kaufco kaufco changed the title Create rule S6877: SequencedCollection reversed view should be used instead of Collections.reverse for read-only lists Create rule S6877: SequencedCollection reversed view should be used instead of reverse copy Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants