-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S6838: @Bean methods for Singleton should not be invoked in @Configuration when proxyBeanMethods is false #3367
Conversation
d3ba2a5
to
9c99c79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising and complementary to S2229, we could add a few more improvements to clarify the scope and examples
3864b37
to
a750636
Compare
SonarQube Quality Gate for 'rspec-tools' |
SonarQube Quality Gate for 'rspec-frontend' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏿 Thanks for the changes
…Methods are disable in @configuration
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
* Change the type from code smell to bug * Limit the impacted software quality to reliability * Change the remediation time to 10 min as understanding and the fixing the issue might require a little more time than expected
a750636
to
65e00a6
Compare
Quality Gate passed for 'rspec-frontend'Kudos, no new issues were introduced! 0 New issues |
Quality Gate passed for 'rspec-tools'Kudos, no new issues were introduced! 0 New issues |
Implemented as part of SONARJAVA-4685 |
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: