Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6838: @Bean methods for Singleton should not be invoked in @Configuration when proxyBeanMethods is false #3367

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the java label Oct 25, 2023
@ADarko22 ADarko22 changed the title Create rule S6838 Create rule S6838: @Bean methods should not be called when Proxy Bean Methods are disable in @Configuration Oct 25, 2023
@ADarko22 ADarko22 changed the title Create rule S6838: @Bean methods should not be called when Proxy Bean Methods are disable in @Configuration Create rule S6838: @Bean methods for Singleton should not be invoked in @Configuration when proxyBeanMethods is false Oct 26, 2023
@ADarko22 ADarko22 force-pushed the rule/add-RSPEC-S6838 branch from d3ba2a5 to 9c99c79 Compare October 26, 2023 08:45
@ADarko22 ADarko22 marked this pull request as ready for review October 26, 2023 08:46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising and complementary to S2229, we could add a few more improvements to clarify the scope and examples

rules/S6838/java/metadata.json Outdated Show resolved Hide resolved
rules/S6838/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6838/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6838/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6838/java/rule.adoc Outdated Show resolved Hide resolved
rules/S6838/java/rule.adoc Outdated Show resolved Hide resolved
@ADarko22 ADarko22 force-pushed the rule/add-RSPEC-S6838 branch 5 times, most recently from 3864b37 to a750636 Compare October 26, 2023 11:51
@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿 Thanks for the changes

ADarko22 and others added 9 commits November 29, 2023 10:31
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
* Change the type from code smell to bug
* Limit the impacted software quality to reliability
* Change the remediation time to 10 min as understanding and the fixing
  the issue might require a little more time than expected
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@dorian-burihabwa-sonarsource
Copy link
Contributor

Implemented as part of SONARJAVA-4685

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource merged commit 55ab74a into master Dec 7, 2023
10 of 11 checks passed
@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource deleted the rule/add-RSPEC-S6838 branch December 7, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants