Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6752: Artifactory tokens should not be disclosed #3023

Merged
merged 11 commits into from
Sep 20, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2023

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@gaetan-ferry-sonarsource gaetan-ferry-sonarsource changed the title Create rule S6752 Create rule S6752: Artifactory tokens should not be disclosed Sep 7, 2023
@gaetan-ferry-sonarsource gaetan-ferry-sonarsource changed the title Create rule S6752: Artifactory tokens should not be disclosed Create rule S6752: test tokens should not be disclosed Sep 12, 2023
@gaetan-ferry-sonarsource gaetan-ferry-sonarsource changed the title Create rule S6752: test tokens should not be disclosed Create rule S6752: Artifactory tokens should not be disclosed Sep 18, 2023
@gaetan-ferry-sonarsource gaetan-ferry-sonarsource marked this pull request as ready for review September 18, 2023 13:36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a very small suggestion


:example_secret: AKCp8vLnDPZeVA29WylUNdaT54Pg2E9rx8gJWfbPCw2Wsb0UCAEmimIPFscGbJPYEUhXVBCRQ
:example_name: artifactory_token
:example_env: artifactory_token

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion: use capitals for the environment variable.

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gaetan-ferry-sonarsource gaetan-ferry-sonarsource merged commit 7fbb1cf into master Sep 20, 2023
@gaetan-ferry-sonarsource gaetan-ferry-sonarsource deleted the rule/add-RSPEC-S6752 branch September 20, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants