Skip to content

Commit

Permalink
Add text
Browse files Browse the repository at this point in the history
  • Loading branch information
loris-s-sonarsource committed Nov 14, 2024
1 parent 2372e9c commit bbaf63f
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 24 deletions.
8 changes: 3 additions & 5 deletions rules/S6762/secrets/rule.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@ If an attacker gains access to a Grafana personal access token or Granafa Cloud

Depending on the permissions given to the secret, the impact might range from the compromise of the data of some dashboards to a full takeover of the Grafana environment.

include::../../../shared_content/secrets/impact/data_compromise.adoc[]

==== Application takeover
:service_name: Grafana

With control over the Grafana application, the attacker can modify dashboards, alter data sources, or inject malicious code. This can result in the manipulation of displayed data, misleading visualizations, or even the introduction of backdoors for further exploitation.
include::../../../shared_content/secrets/impact/data_compromise.adoc[]

The attacker may even attempt to escalate their privileges within the Grafana environment. By gaining administrative access or higher-level permissions, they can perform more significant actions, such as modifying access controls, adding or deleting users, or changing system configurations.
include::../../../shared_content/secrets/impact/dataviz_takeover.adoc[]

== How to fix it

Expand Down
2 changes: 1 addition & 1 deletion rules/S7161/secrets/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"title": "SECRET_TYPE should not be disclosed",
"title": "Tableau secrets should not be disclosed",
"type": "VULNERABILITY",
"code": {
"impacts": {
Expand Down
32 changes: 14 additions & 18 deletions rules/S7161/secrets/rule.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,24 @@ include::../../../shared_content/secrets/rationale.adoc[]

=== What is the potential impact?

// Optional: Give a general description of the secret and what it's used for.
Tableau secrets scopes depend on the type of secret. From the most impactful to
the least:

1. Account passwords
2. Personal access tokens (PAT)
3. "Credentials token", received after a SignIn request

Their scopes vary in terms of lifetime, access, and impact.

Below are some real-world scenarios that illustrate some impacts of an attacker
exploiting the secret.

// Set value that can be used to refer to the type of secret in, for example:
// "An attacker can use this {secret_type} to ..."
:secret_type: secret
:service_name: Tableau

// Where possible, use predefined content for common impacts. This content can
// be found in the folder "shared_content/secrets/impact".
// When using predefined content, search for any required variables to be set and include them in this file.
// Not adding them will not trigger warnings.
include::../../../shared_content/secrets/impact/data_compromise.adoc[]

//include::../../../shared_content/secrets/impact/some_impact.adoc[]
include::../../../shared_content/secrets/impact/dataviz_takeover.adoc[]

== How to fix it

Expand All @@ -31,20 +34,13 @@ include::../../../shared_content/secrets/fix/vault.adoc[]

=== Code examples

:example_secret: example_secret_value
:example_name: java-property-name
:example_env: ENV_VAR_NAME
:example_secret: FMWBZfscS96flnAPXVY06w|QQsOzThG6hqNvZcd6OPIpZs88lgcYTcb|77bfee95-c689-4fd1-a7e0-2cf050adbbb2
:example_name: tableau-auth
:example_env: TABLEAU_AUTH

include::../../../shared_content/secrets/examples.adoc[]

//=== How does this work?

//=== Pitfalls

//=== Going the extra mile

== Resources

include::../../../shared_content/secrets/resources/standards.adoc[]

//=== Benchmarks
12 changes: 12 additions & 0 deletions shared_content/secrets/impact/dataviz_takeover.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
==== Dataviz Corruption and Takeover

With control over the {service_name} application, the attacker can modify
dashboards, alter data sources, or inject malicious code. This can result in the
manipulation of displayed data, misleading visualizations, or even the
introduction of backdoors for further exploitation.

The attacker may even attempt to escalate their privileges within the
{service_name} environment. By gaining administrative access or higher-level
permissions, they can perform more significant actions, such as modifying access
controls, adding or deleting users, or changing system configurations.

0 comments on commit bbaf63f

Please sign in to comment.