Skip to content

Commit

Permalink
Update RSPEC?
Browse files Browse the repository at this point in the history
  • Loading branch information
hendrik-buchwald-sonarsource committed Nov 14, 2024
1 parent 2982732 commit ac34869
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 23 deletions.
2 changes: 1 addition & 1 deletion rules/S7163/secrets/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"title": "SECRET_TYPE should not be disclosed",
"title": "Mandrill API keys should not be disclosed",
"type": "VULNERABILITY",
"code": {
"impacts": {
Expand Down
29 changes: 7 additions & 22 deletions rules/S7163/secrets/rule.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,14 @@ include::../../../shared_content/secrets/rationale.adoc[]

=== What is the potential impact?

// Optional: Give a general description of the secret and what it's used for.

Below are some real-world scenarios that illustrate some impacts of an attacker
exploiting the secret.

// Set value that can be used to refer to the type of secret in, for example:
// "An attacker can use this {secret_type} to ..."
:secret_type: secret
:secret_type: API key

// Where possible, use predefined content for common impacts. This content can
// be found in the folder "shared_content/secrets/impact".
// When using predefined content, search for any required variables to be set and include them in this file.
// Not adding them will not trigger warnings.
include::../../../shared_content/secrets/impact/phishing.adoc[]

//include::../../../shared_content/secrets/impact/some_impact.adoc[]
include::../../../shared_content/secrets/impact/financial_loss.adoc[]

== How to fix it

Expand All @@ -31,20 +24,12 @@ include::../../../shared_content/secrets/fix/vault.adoc[]

=== Code examples

:example_secret: example_secret_value
:example_name: java-property-name
:example_env: ENV_VAR_NAME
:example_secret: md-tYmfLurJdDlP4wDdOqEzZA
:example_name: mandrill-api-key
:example_env: MANDRILL_API_KEY

include::../../../shared_content/secrets/examples.adoc[]

//=== How does this work?

//=== Pitfalls

//=== Going the extra mile

== Resources

include::../../../shared_content/secrets/resources/standards.adoc[]

//=== Benchmarks
include::../../../shared_content/secrets/resources/standards.adoc[]

0 comments on commit ac34869

Please sign in to comment.