Create rule S7171: Mailgun SMTP credentials should not be disclosed (#…

…4512) * Create rule S7171 * Add RSPEC content * Remove comments from rule.adoc --------- Co-authored-by: jamie-anderson-sonarsource <[email protected]> Co-authored-by: Jamie Anderson <[email protected]>
SonarSource · Nov 15, 2024 · 3fca2aa · 3fca2aa
1 parent 402e3ea
commit 3fca2aa
Show file tree

Hide file tree

Showing 3 changed files with 103 additions and 0 deletions.
diff --git a/rules/S7171/metadata.json b/rules/S7171/metadata.json
@@ -0,0 +1,2 @@
+{
+}
diff --git a/rules/S7171/secrets/metadata.json b/rules/S7171/secrets/metadata.json
@@ -0,0 +1,56 @@
+{
+  "title": "Mailgun SMTP credentials should not be disclosed",
+  "type": "VULNERABILITY",
+  "code": {
+    "impacts": {
+      "SECURITY": "HIGH"
+    },
+    "attribute": "TRUSTWORTHY"
+  },
+  "status": "ready",
+  "remediation": {
+    "func": "Constant\/Issue",
+    "constantCost": "30min"
+  },
+  "tags": [
+    "cwe",
+    "cert"
+  ],
+  "defaultSeverity": "Blocker",
+  "ruleSpecification": "RSPEC-7171",
+  "sqKey": "S7171",
+  "scope": "All",
+  "securityStandards": {
+    "CWE": [
+      798,
+      259
+    ],
+    "OWASP": [
+      "A3"
+    ],
+    "CERT": [
+      "MSC03-J."
+    ],
+    "OWASP Top 10 2021": [
+      "A7"
+    ],
+    "PCI DSS 3.2": [
+      "6.5.10"
+    ],
+    "PCI DSS 4.0": [
+      "6.2.4"
+    ],
+    "ASVS 4.0": [
+      "2.10.4",
+      "3.5.2",
+      "6.4.1"
+    ],
+    "STIG ASD_V5R3": [
+      "V-222642"
+    ]
+  },
+  "defaultQualityProfiles": [
+    "Sonar way"
+  ],
+  "quickfix": "unknown"
+}
diff --git a/rules/S7171/secrets/rule.adoc b/rules/S7171/secrets/rule.adoc
@@ -0,0 +1,45 @@
+
+include::../../../shared_content/secrets/description.adoc[]
+
+== Why is this an issue?
+
+include::../../../shared_content/secrets/rationale.adoc[]
+
+=== What is the potential impact?
+
+Below are some real-world scenarios that illustrate some impacts of an attacker
+exploiting the secret.
+
+:secret_type: credentials
+
+include::../../../shared_content/secrets/impact/phishing.adoc[]
+
+include::../../../shared_content/secrets/impact/exceed_rate_limits.adoc[]
+
+include::../../../shared_content/secrets/impact/suspicious_activities_termination.adoc[]
+
+== How to fix it
+
+include::../../../shared_content/secrets/fix/revoke.adoc[]
+
+include::../../../shared_content/secrets/fix/vault.adoc[]
+
+=== Code examples
+
+:example_secret: aae73f3aa79607cabffe7cd69e37e478-058ba5af-d1a3a279
+:example_name: mailgun.smtp.password
+:example_env: MAILGUN_SMTP_PASSWORD
+
+include::../../../shared_content/secrets/examples.adoc[]
+
+//=== How does this work?
+
+//=== Pitfalls
+
+//=== Going the extra mile
+
+== Resources
+
+include::../../../shared_content/secrets/resources/standards.adoc[]
+
+//=== Benchmarks