Merge branch 'master' into rule/S5973-add-javascript

frontend/public/covered_rules.json

@@ -3605,6 +3605,8 @@
     "S6853": "SonarJS 10.10.0.24774",
     "S6854": "SonarJS 10.10.0.24774",
     "S6855": "SonarJS 10.10.0.24774",
+    "S6859": "SonarJS master",
+    "S6861": "SonarJS master",
     "S878": "SonarJS 3.3.0.5702",
     "S881": "SonarJS 3.3.0.5702",
     "S888": "SonarJS 3.3.0.5702",
@@ -5807,6 +5809,8 @@
     "S6853": "SonarJS 10.10.0.24774",
     "S6854": "SonarJS 10.10.0.24774",
     "S6855": "SonarJS 10.10.0.24774",
+    "S6859": "SonarJS master",
+    "S6861": "SonarJS master",
     "S878": "SonarJS 6.0.0.9595",
     "S881": "SonarJS 6.1.0.11503",
     "S888": "SonarJS 6.2.0.12043",

rules/S3743/cfamily/rule.adoc

@@ -91,12 +91,6 @@ void init() noexcept(true) { // compliant because ...
 
 Destructors are not handled by this rule because there is a specific rule about exceptions in destructors (see ExceptionInDestructor).
 
-
-== Resources
-
-* https://www.hlsl.co.uk/blog/2017/12/1/c-noexcept-and-move-constructors-effect-on-performance-in-stl-containers[{cpp} noexcept and move constructors effect on performance in STL containers]
-
-
 ifdef::env-github,rspecator-view[]
 
 '''

rules/S6861/javascript/metadata.json

@@ -0,0 +1,24 @@
+{
+  "title": "Mutable variables should not be exported",
+  "type": "CODE_SMELL",
+  "status": "ready",
+  "remediation": {
+    "func": "Constant\/Issue",
+    "constantCost": "5min"
+  },
+  "tags": [
+  ],
+  "defaultSeverity": "Major",
+  "ruleSpecification": "RSPEC-6861",
+  "sqKey": "S6861",
+  "scope": "All",
+  "defaultQualityProfiles": ["Sonar way"],
+  "quickfix": "infeasible",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "HIGH",
+      "RELIABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  }
+}

rules/S6861/javascript/rule.adoc

@@ -0,0 +1,51 @@
+== Why is this an issue?
+
+In JavaScript, a mutable variable is one whose value can be changed after it has been initially set. This is in contrast to immutable variables, whose values cannot be changed once they are set.
+
+Exporting mutable variables can lead to unpredictable behavior and bugs in your code. This is because any module that imports the variable can change its value. If multiple modules import and change the value of the same variable, it can become difficult to track what the current value of the variable is and which module changed it last.
+
+== How to fix it
+
+If the value of the variable does not need to change, you can declare it as a constant using the ``++const++`` keyword. Alternatively, if you have a group of related variables that need to be mutable, consider using a class to encapsulate them. You can then export an instance of the class, or a factory function that creates instances of the class.
+
+=== Code examples
+
+==== Noncompliant code example
+
+[source,javascript]
+----
+let mutableVar = "initial value";
+
+export { mutableVar }; // Noncompliant
+----
+
+==== Compliant solution
+
+[source,javascript]
+----
+const immutableVar = "constant value";
+export { immutableVar };
+----
+
+or
+
+[source,javascript]
+----
+class MyClass {
+  constructor() {
+    this.mutableVar = "initial value";
+  }
+}
+
+export function createMyClass() {
+  return new MyClass();
+}
+----
+
+== Resources
+=== Documentation
+
+* MDN web docs - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let[let]
+* MDN web docs - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const[const]
+* MDN web docs - https://developer.mozilla.org/en-US/docs/Glossary/Mutable[Mutable]
+* MDN web docs - https://developer.mozilla.org/en-US/docs/Glossary/Immutable[Immutable]

rules/S6861/metadata.json

@@ -0,0 +1,2 @@
+{
+}