Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate API call to get dynamic data from old Weather Underground service (defunct) #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Eliminate API call to get dynamic data from old Weather Underground service (defunct) #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19d5d4a
Update WeatherServlet.java
irobins Oct 31, 2024
4a4d641
Merge pull request #1 from easejdemos/irobins-patch-1
irobins Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/com/acme/modres/WeatherServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,16 @@ protected void doGet(HttpServletRequest request,
String weatherAPIKey = System.getenv(WEATHER_API_KEY);
String mockedKey = mockKey(weatherAPIKey);
logger.log(Level.FINE, "weatherAPIKey is " + mockedKey);


/*
if (weatherAPIKey != null && weatherAPIKey.trim().length() > 0) {
logger.info("weatherAPIKey is found, system will provide the real time weather data for the city " + city);
getRealTimeWeatherData(city, weatherAPIKey, response);
} else {
} else {
logger.info("weatherAPIKey is not found, will provide the weather data dated August 10th, 2018 for the city " + city);
*/
getDefaultWeatherData(city, response);
}
// }
}

private void getRealTimeWeatherData(String city, String apiKey, HttpServletResponse response)
Expand Down