Refactoring to create staff user for Representation Virtual Office #18

javikalsan · 2024-09-30T14:36:12Z

Description

Due to the annexation of the Representation ERP to Commercialization one, we carried out this refactor to create and identify the staff user in a more consistent way in this new scenario.

Changes

Specify in visible strings the word representation to distinguish from commercialization properly
New implementation to create and identify the user staff for Representation Virtual Office, considering more complex cases we can find in comer erp (dupped nifs, users already with addresses...)

Checklist

Justify any unchecked point:

Changed code is covered by tests.
Relevant changes are explained in the "Unreleased" section of the CHANGES.md file.
That section includes "Upgrade notes" with any config, dependency or deploy tweek needed on development and server setups. -> None beyond the normal update process
Changes on the setup process (development, testing, production) have been updated in the proper documentation. -> None beyond the normal update process

Observations

N/A

Please, review

ORM Many2Many abstraction
Tests helpers
Production code helpers
Feedback: what is the partner address order? We concluded order is id ASC

How to check the new features

Tests driven

./dodestral.sh -m som_ov_users --no-requirements -t test_res_users.ResUsersTests
./dodestral.sh -m som_ov_users --no-requirements

Via OpenERP client

Go to Administration - Users, here you'll find the wizard clicking in Actions button

Deploy notes

N/A

sonarqubecloud · 2024-10-02T13:46:27Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Co-authored-by: David García Garzón <[email protected]>

with comer and repre integration, we have two ov's, so lets explicit which one the texts refer to. Co-authored-by: David García Garzón <[email protected]>

Co-authored-by: David García Garzón <[email protected]>

besides having a partner address Co-authored-by: David García Garzón <[email protected]>

Co-authored-by: David García Garzón <[email protected]>

test__ovrepre_provisioning_data__non_staff_with_linked_secondary_address Co-authored-by: David García Garzón <[email protected]>

Co-authored-by: David García Garzón <[email protected]>

- The field value strategy to handle readonly was causing the imposibility to modify the value when leaving the input focus and the unexpected behavior of setting field value to `False`

Co-authored-by: David García Garzón <[email protected]>

Field readonly was sent depending on having a value. When the user gave a value, the field could not be edited anymore. Also readonly fields, are not used to update wizard data so whichever we store as readonly is received as False. So we decoupled the real value of the fields from the attribute telling that it should be readonly. And considering that we could receive False for the values. Co-authored-by: David García Garzón <[email protected]>

Co-authored-by: David García Garzón <[email protected]>

- Declaring required in view is breaking the readonly behavior and required was not working properly. Declaring the required field behavior in the model is working. Co-authored-by: David García Garzón <[email protected]>

Co-authored-by: David García Garzón <[email protected]>

` Co-authored-by: David García Garzón <[email protected]>

Co-authored-by: David García Garzón <[email protected]>

The lesser address id related to a partner is considered the primary one. So in order to make the unlinked address to be considered a secondary one we must assure that the secondary address is defined the later in the xml. Co-authored-by: David García Garzón <[email protected]>

Co-authored-by: David García Garzón <[email protected]>

sonarqubecloud · 2024-11-07T11:12:25Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-11-07T11:17:07Z

Test Results

122 tests 122 ✅ 6s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 61d5ed6.

javikalsan assigned javikalsan and vokimon and unassigned javikalsan Sep 30, 2024

javikalsan added the ask Integration will be blocked until reviewed label Sep 30, 2024

vokimon requested a review from destanyol October 2, 2024 13:48

MariteSomEnergia and others added 23 commits November 7, 2024 12:10

♻ prIvisioning -> provisioning

82d4cde

Co-authored-by: David García Garzón <[email protected]>

🌐 texts refer explicitly to our ov instance

e1c3732

with comer and repre integration, we have two ov's, so lets explicit which one the texts refer to. Co-authored-by: David García Garzón <[email protected]>

✨ Added category for ov staff

7ff364b

Co-authored-by: David García Garzón <[email protected]>

✨ check the category in is_staff

d215198

Co-authored-by: David García Garzón <[email protected]>

✨ Wizard sets staff category

c6e08d1

Co-authored-by: David García Garzón <[email protected]>

✨ api checks staff category

d99beaa

besides having a partner address Co-authored-by: David García Garzón <[email protected]>

♻ avoiding double query for partner_address

6c38c5b

Co-authored-by: David García Garzón <[email protected]>

♻ Converge both staff checks

c88d4bf

Co-authored-by: David García Garzón <[email protected]>

📝 case analisys for staff provisioning

ae079b4

Co-authored-by: David García Garzón <[email protected]>

📝 One more case

60f31b0

Co-authored-by: David García Garzón <[email protected]>

🐛 Show selected user info

2679c99

Co-authored-by: David García Garzón <[email protected]>

✅ test__ovrepre_provisioning_data__base_case

01bba3f

Co-authored-by: David García Garzón <[email protected]>

✅ test__ovrepre_provisioning_data__non_staff_address_linked

cd5fd89

Co-authored-by: David García Garzón <[email protected]>

✅ test__ovrepre_provisioning_data__already_staff__gives_error

6d5020d

Co-authored-by: David García Garzón <[email protected]>

✅ Skipped test

5fe02bd

test__ovrepre_provisioning_data__non_staff_with_linked_secondary_address Co-authored-by: David García Garzón <[email protected]>

🚧📝 Update use cases

854bb84

Co-authored-by: David García Garzón <[email protected]>

📝 Update edge case

7d759e0

Co-authored-by: David García Garzón <[email protected]>

♻️ Rename init_wizard_to_turn_into_representation_staff

e96b76f

Co-authored-by: David García Garzón <[email protected]>

✨ Take first partner address instead user's one

5255001

Co-authored-by: David García Garzón <[email protected]>

♻️ handle no linked partner first

316d8e4

Co-authored-by: David García Garzón <[email protected]>

✨ user_linked_to_a_partnerless_address

bbde9ac

Co-authored-by: David García Garzón <[email protected]>

✨ Fail when incosistent partner information

65fea96

Co-authored-by: David García Garzón <[email protected]>

🐛 VAT in demo data already existed in base module

ebc8028

Co-authored-by: David García Garzón <[email protected]>

javikalsan and others added 27 commits November 7, 2024 12:10

🐛✅ res_user_is_already_staff

b088a89

♻️ Remove unused code

cb513cb

📝 Update design todo's

abd8e1e

✨ Use res_users process_create_staff_result

4172514

♻️ First time execution identification strategy for default_get

b4f648a

🐛 Use wizard state to handle readonly attribute field

c9f8e54

- The field value strategy to handle readonly was causing the imposibility to modify the value when leaving the input focus and the unexpected behavior of setting field value to `False`

📝 Update changes

fd23554

✅ Add res_users_linked_non_staff demo data

b7cf88b

Co-authored-by: David García Garzón <[email protected]>

♻️ Rename tests

1788985

Co-authored-by: David García Garzón <[email protected]>

✨ Process fn: when linked to non staff partner adds staff category

80dc4d8

Co-authored-by: David García Garzón <[email protected]>

✨ Process fn: Linked to a secondary address keeps it

f581831

Co-authored-by: David García Garzón <[email protected]>

🧹 Typo

5c1b4ed

Co-authored-by: David García Garzón <[email protected]>

🐛 Make vat and email fields required

61b5dc8

Co-authored-by: David García Garzón <[email protected]>

🐛 Declare required in model instead of view

87267dd

- Declaring required in view is breaking the readonly behavior and required was not working properly. Declaring the required field behavior in the model is working. Co-authored-by: David García Garzón <[email protected]>

♻️ Inverted logic for vat not found

3cd0d2d

Co-authored-by: David García Garzón <[email protected]>

🎨 moved inner helper functions at the top

8b7ef1f

Co-authored-by: David García Garzón <[email protected]>

♻️ reused and renaming address_already_linked

3fd9004

Co-authored-by: David García Garzón <[email protected]>

♻️ warnings are composed with more simple code

4547fa7

` Co-authored-by: David García Garzón <[email protected]>

♻️ Rename linked non staff demo data

cb91503

Co-authored-by: David García Garzón <[email protected]>

♻️ Rename unlinked by partnerless and use new demo data

248f1e8

Co-authored-by: David García Garzón <[email protected]>

♻️ Rename unlinked by partnerless

ce8de32

Co-authored-by: David García Garzón <[email protected]>

♻️ ✅ using new demo data linked_non_staff

23a5344

Co-authored-by: David García Garzón <[email protected]>

♻️: ✅ using linked_non_staff in more cases

ce4ef1a

Co-authored-by: David García Garzón <[email protected]>

📝 docs

f449060

🧹 Remove todos

61d5ed6

Co-authored-by: David García Garzón <[email protected]>

oriolpiera force-pushed the REF_create_staff_user branch from 2204f03 to 61d5ed6 Compare November 7, 2024 11:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring to create staff user for Representation Virtual Office #18

Refactoring to create staff user for Representation Virtual Office #18

javikalsan commented Sep 30, 2024 •

edited

Loading

sonarqubecloud bot commented Oct 2, 2024

sonarqubecloud bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

Refactoring to create staff user for Representation Virtual Office #18

Are you sure you want to change the base?

Refactoring to create staff user for Representation Virtual Office #18

Conversation

javikalsan commented Sep 30, 2024 • edited Loading

Description

Changes

Checklist

Observations

Please, review

How to check the new features

Tests driven

Via OpenERP client

Deploy notes

sonarqubecloud bot commented Oct 2, 2024

Quality Gate passed

sonarqubecloud bot commented Nov 7, 2024

Quality Gate passed

github-actions bot commented Nov 7, 2024

Test Results

javikalsan commented Sep 30, 2024 •

edited

Loading