Rest directive: don't send body for GET (#307)

Soluto · Mar 20, 2021 · ec44701 · ec44701
1 parent 58cba31
commit ec44701
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/services/src/modules/directives/rest/datasource.spec.ts b/services/src/modules/directives/rest/datasource.spec.ts
@@ -247,6 +247,18 @@ const testCases: [string, TestCase][] = [
       fieldResolverParams: {},
     },
   ],
+  [
+    'GET with arg named "input"',
+    {
+      setup: () => nock(remoteHost).get('/').reply(200, remoteHostResponse),
+      restParams: {},
+      fieldResolverParams: {
+        args: {
+          input: '1',
+        },
+      },
+    },
+  ],
 ];
 
 const emptyContext = {

diff --git a/services/src/modules/directives/rest/datasource.ts b/services/src/modules/directives/rest/datasource.ts
@@ -45,6 +45,9 @@ export class RESTDirectiveDataSource extends RESTDataSource<RequestContext> {
   }
 
   private setBody(requestParams: RequestParams, params: RestParams, fieldResolverParams: FieldResolverParams) {
+    if (!requestParams.method || ['GET', 'HEAD'].includes(requestParams.method.toUpperCase())) {
+      return;
+    }
     const { body: bodyObj, bodyArg } = params;
     if (bodyObj && bodyArg) {
       throw new Error('Set either "body" or "bodyArg" argument but not both');