Avoid BlankNodes inside PATCHes

[michielbdejong]

The spec prohibits BlankNodes inside N3 PATCH entries, so let's use a NamedNode here?

Hopefully this can fix solid-contrib/pivot#31

I haven't tested this code yet.

[michielbdejong]

Ah, and the unit tests are already failing :) NamedNode IRI "mock_app_id" must be absolute.

[michielbdejong]

Unit tests fixed. I'll see if I can test it manually in a development setup too.

[michielbdejong]

I tried testing these changes by loading the basicPreferencePane into the Solid Pane Tester, but didn't get past this screen:

Can someone else maybe test if this PR works as desired?

[bourgeoa]

I'm wondering if other panes have the same issue like contacts ...
It can happen in every updater.update where text/N3 patch is required

Isn't this is basically a rdflib issue
https://github.com/linkeddata/rdflib.js/blob/82f693dc10d5b915f97eedeab5351cf831c3611e/src/update-manager.ts#L815

[michielbdejong]

I searched for occurrences of updater.update across Solid OS and at first glance it looks like this was the only place where we were including triples with blank nodes.

Apart from the unit tests passing, thanks to @bourgeoa I was able to test this on http://solidcommunity.net:8443 and update my trusted applications successfully. The request it makes now contains a named node instead of a blank node, and CSS accepts it:

curl 'https://michielbdejong.solidcommunity.net:8443/profile/card' \
  -X 'PATCH' \
  -H '...'\
  -H 'content-type: text/n3' \
  --data-raw $'\n@prefix solid: <http://www.w3.org/ns/solid/terms#>.\n@prefix ex: <http://www.example.org/terms#>.\n\n_:patch\n\n      solid:inserts {\n        <https://michielbdejong.solidcommunity.net:8443/profile/card#me> <http://www.w3.org/ns/auth/acl#trustedApp> <https://michielbdejong.solidcommunity.net:8443/profile/card#nd3xr> .\n        <https://michielbdejong.solidcommunity.net:8443/profile/card#nd3xr> <http://www.w3.org/ns/auth/acl#origin> <http://localhost:3000> .\n        <https://michielbdejong.solidcommunity.net:8443/profile/card#nd3xr> <http://www.w3.org/ns/auth/acl#mode> <http://www.w3.org/ns/auth/acl#Read> .\n      };   a solid:InsertDeletePatch .\n'

[bourgeoa]

I opened a question to CSS CommunitySolidServer/CommunitySolidServer#1968

[michielbdejong]

@bourgeoa can we merge this now? Or you don't think this is something we should change in solid-panes?

[bourgeoa]

I principle yes. Can we wait a few days to see if something comes out from matrix discussion ?
I also tested on NSS with no issue. Old and new trustedApp are created/updated/deleted.

In the mean time you can use [email protected] that includes the patch