Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that support surfaces get filtered out unexpectly #7988

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Jan 9, 2025

Fix #7935

image

#ifdef SLIC3R_DEBUG
SupportGeneratorLayersPtr layers_sorted =
#endif // SLIC3R_DEBUG
generate_support_layers(object, raft_layers, bottom_contacts, top_contacts, intermediate_layers, interface_layers, base_interface_layers);
Copy link
Collaborator Author

@Noisyfox Noisyfox Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part that fixes the problem. Everything else are changes needed to make the code compile. No logic changes at all EXCEPT this one.

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Jan 9, 2025

This is also one more step towards syncing the support code with BBS.

@Noisyfox Noisyfox merged commit f3fddcb into SoftFever:main Jan 22, 2025
16 checks passed
@Noisyfox Noisyfox deleted the bugfox/support-interface-bbs branch January 22, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports (multimaterial): Changing Top Z distance inhibits bottom interface material change
1 participant