imgui: use freetype for font rendering #7409
Open
+898
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add and enable freetype font renderer for imgui
For a locales with long enough "Used filament" localization, line type table may render crooked with overlapping column headers. This change reworks column width calculations getting rid of heuristics based on the presence of "Display" column.
|
Looks like it works on Windows. Fonts are a bit crisper. Almost too crisp. Oversampling the font atlas texture by setting this line:
to
made it look a bit better. Though, this will quadruple the font atlas texture memory footprint. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate freetype as font rendering engine for imgui. This makes all texts rendered by imgui sharper.
Additionally, fix column width calculation for "Line type" statistics table. This bug happens for locales with long enough "Used filament" localizations (like Ukranian one).
Screenshots/Recordings/Graphs
Original (stb_truetype) imgui font rendering (Orca 2.2.0 release build):
Freetype font rendering:
Representation of the column width bug (Orca 2.2.0 release build):
Tests
Tested on Linux only.