Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunkloading fixes #342

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Chunkloading fixes #342

merged 2 commits into from
Nov 27, 2024

Conversation

Alvsch
Copy link
Contributor

@Alvsch Alvsch commented Nov 25, 2024

Description

Testing

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test
  • I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

@Alvsch Alvsch changed the title Chunk Chunkloading fixes Nov 25, 2024
@Alvsch
Copy link
Contributor Author

Alvsch commented Nov 26, 2024

Ill rather have this pr be merged before fixing the last issue.

@Alvsch Alvsch marked this pull request as ready for review November 26, 2024 18:48
@DataM0del
Copy link
Contributor

This fixes #253,
please add "Fixes #253" to the PR body, when the PR is merged, issue #253 will be closed automatically.

@Snowiiii
Copy link
Owner

For some reason i still get error messages, When increasing my render distance from 4 to 12 like in #253 Marking a chunk as not watched, but was vacant! (Vector2 { x: 13, z: -2 })

@Alvsch
Copy link
Contributor Author

Alvsch commented Nov 27, 2024

For some reason i still get error messages, When increasing my render distance from 4 to 12 like in #253 Marking a chunk as not watched, but was vacant! (Vector2 { x: 13, z: -2 })

I'm not able to replicate it, but it shouldn't cause any weird behaviours.

@Snowiiii Snowiiii merged commit df25c1f into Snowiiii:master Nov 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increasing (in game) render distance (4 -> 12) breaks chunk generation
3 participants