Added World Time #321
Merged
Added World Time #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowiiii
reviewed
Nov 20, 2024
|
Anything left for this PR? |
DataM0del
approved these changes
Nov 22, 2024
Snowiiii
reviewed
Nov 23, 2024
|
Should be all set now |
|
Could you please follow the Vanilla /time rules. See https://minecraft.wiki/w/Commands/time
Should be not hard to implement |
|
Time command should be all set now |
|
Overall looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added world time. Does not change global lighting. Added corresponding time command and all subfeatures.
Future work (under different PR):
Testing
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmtcargo clippy