Fix New-ServiceNowChangeTask not linking to parent (#256)

Snow-Shell · Nov 19, 2023 · b9e890d · b9e890d
1 parent 2971be1
commit b9e890d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 16 deletions.
diff --git a/ServiceNow/Public/New-ServiceNowChangeRequest.ps1 b/ServiceNow/Public/New-ServiceNowChangeRequest.ps1
@@ -35,7 +35,7 @@
 .PARAMETER ConfigurationItem
     Full name or sys_id of the configuration item to be associated with the change
 
-.PARAMETER InputData
+.PARAMETER CustomField
     Field values which aren't one of the built in function properties
 
 .PARAMETER ServiceNowSession
@@ -109,8 +109,8 @@ function New-ServiceNowChangeRequest {
         [string] $ConfigurationItem,
 
         [parameter()]
-        [Alias('CustomFields')]
-        [hashtable] $InputData,
+        [Alias('CustomFields', 'InputData')]
+        [hashtable] $CustomField,
 
         [Parameter()]
         [Hashtable] $Connection,
@@ -141,12 +141,12 @@ function New-ServiceNowChangeRequest {
         }
 
         # add custom fields
-        $duplicateValues = ForEach ($Key in $InputData.Keys) {
+        $duplicateValues = ForEach ($Key in $CustomField.Keys) {
             If ( $values.ContainsKey($Key) ) {
                 $Key
             }
             Else {
-                $values.Add($Key, $InputData[$Key])
+                $values.Add($Key, $CustomField[$Key])
             }
         }
 

diff --git a/ServiceNow/Public/New-ServiceNowChangeTask.ps1 b/ServiceNow/Public/New-ServiceNowChangeTask.ps1
@@ -31,7 +31,7 @@ function New-ServiceNowChangeTask {
         Return the newly created item details
 
     .EXAMPLE
-        New-ServiceNowChangeTask -ChangeRequest RITM0010001 -ShortDescription 'New PS change request' -Description 'This change request was created from Powershell' -AssignmentGroup ServiceDesk
+        New-ServiceNowChangeTask -ChangeRequest CHG0010001 -ShortDescription 'New PS change request' -Description 'This change request was created from Powershell' -AssignmentGroup ServiceDesk
 
         Create a new task
 
@@ -82,6 +82,7 @@ function New-ServiceNowChangeTask {
         switch ($PSBoundParameters.Keys) {
             'ChangeRequest' {
                 $createValues.parent = $ChangeRequest
+                $createValues.change_request = $ChangeRequest
             }
 
             'ShortDescription' {
@@ -101,11 +102,11 @@ function New-ServiceNowChangeTask {
             }
         }
 
-        $CustomField.GetEnumerator() | ForEach-Object {
-            if ( $createValues.($_.Key) ) {
-                Write-Warning ('Custom field {0} has already been added via parameter' -f $_.Key)
+        foreach ($key in $CustomField.Keys) {
+            if ( $createValues.$key ) {
+                Write-Warning "Custom field '$key' has already been provided via one of the dedicated parameters"
             } else {
-                $createValues.Add($_.Key, $_.Value)
+                $createValues.Add($key, $CustomField.$key)
             }
         }
 

diff --git a/ServiceNow/Public/New-ServiceNowIncident.ps1 b/ServiceNow/Public/New-ServiceNowIncident.ps1
@@ -29,7 +29,7 @@ Generates a new ServiceNow Incident using predefined or other field values
 .PARAMETER ConfigurationItem
     Full name or sys_id of the configuration item to be associated with the change
 
-.PARAMETER InputData
+.PARAMETER CustomField
     Field values which aren't one of the built in function properties
 
 .PARAMETER ServiceNowSession
@@ -56,7 +56,7 @@ Generate a basic Incident attributed to the caller "UserName" with descriptions,
             Category = "Office"
             Subcategory = "Outlook"
             ConfigurationItem = "UserPC1"
-            InputData = @{u_custom1 = "Custom Field Entry"
+            CustomField = @{u_custom1 = "Custom Field Entry"
                             u_another_custom = "Related Test"}
             }
         New-ServiceNowIncident @IncidentParams
@@ -93,8 +93,8 @@ function New-ServiceNowIncident {
         [string] $ConfigurationItem,
 
         [parameter()]
-        [Alias('CustomFields')]
-        [hashtable] $InputData,
+        [Alias('CustomFields', 'InputData')]
+        [hashtable] $CustomField,
 
         [Parameter()]
         [Hashtable] $Connection,
@@ -124,12 +124,12 @@ function New-ServiceNowIncident {
         }
 
         # add custom fields
-        $duplicateValues = ForEach ($Key in $InputData.Keys) {
+        $duplicateValues = ForEach ($Key in $CustomField.Keys) {
             If ( $values.ContainsKey($Key) ) {
                 $Key
             }
             Else {
-                $values.Add($Key, $InputData[$Key])
+                $values.Add($Key, $CustomField[$Key])
             }
         }