-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for YouTube shorts in the YouTube regexp #619
Conversation
@Zingzy is attempting to deploy a commit to the snailedlt's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you please also add some new URLs to the test file? 😊
Sure, just needed a confirmation I need to add the URLs in this file right? |
@Snailedlt I added the new URLs in the test file, please check |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Zingzy doesn't work in the preview environment for some reason |
@Snailedlt I was testing this branch locally and it was working fine, there must be some problem in the vercel deployment.. I even tested the updated regex with all of the YouTube shorts URLs.. I also visited the |
Hmm, I'll see if I can take a look this weekend. Might just need to redeploy the web app |
Ahh I see what the problem is. The environment variables go towards the prod API, so the changes don't affect the website 😅 |
No worries! Just glad to contribute to this amazing repo 😄 |
@Zingzy I'm glad you enjoy it! Feel free to make issues or PRs if you find anything more that can be improved or fixed :) |
This PR addresses issue #206
Overview
Testing