Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for YouTube shorts in the YouTube regexp #619

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

Zingzy
Copy link
Contributor

@Zingzy Zingzy commented Oct 1, 2024

This PR addresses issue #206

Overview

  • Update the regex to add support for YouTube shorts

Testing

Screenshot 2024-09-29 023356

Copy link

vercel bot commented Oct 1, 2024

@Zingzy is attempting to deploy a commit to the snailedlt's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you please also add some new URLs to the test file? 😊

@Zingzy
Copy link
Contributor Author

Zingzy commented Oct 2, 2024

Thanks for the PR!

Could you please also add some new URLs to the test file? 😊

Sure, just needed a confirmation I need to add the URLs in this file right?

@Zingzy
Copy link
Contributor Author

Zingzy commented Oct 2, 2024

@Snailedlt I added the new URLs in the test file, please check

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
markdown-videos-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 11:45am
markdown-videos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 11:45am

@Snailedlt
Copy link
Owner

@Zingzy doesn't work in the preview environment for some reason Screenshot_2024_1003_153009.png

@Zingzy
Copy link
Contributor Author

Zingzy commented Oct 4, 2024

@Zingzy doesn't work in the preview environment for some reason Screenshot_2024_1003_153009.png

@Snailedlt I was testing this branch locally and it was working fine, there must be some problem in the vercel deployment.. I even tested the updated regex with all of the YouTube shorts URLs.. I also visited the markdown-videos-web preview in the vercel test deployment and the API was able to detect YouTube shorts as expected

Screenshot_4-10-2024_173710_markdown-videos-api-git-fork-zingzy-f1895b-snailedlts-projects vercel app

@Snailedlt
Copy link
Owner

Hmm, I'll see if I can take a look this weekend. Might just need to redeploy the web app

@Snailedlt
Copy link
Owner

Ahh I see what the problem is. The environment variables go towards the prod API, so the changes don't affect the website 😅

@Snailedlt Snailedlt merged commit ec8cf28 into Snailedlt:main Oct 5, 2024
6 checks passed
@Zingzy
Copy link
Contributor Author

Zingzy commented Oct 6, 2024

Ahh I see what the problem is. The environment variables go towards the prod API, so the changes don't affect the website 😅

No worries! Just glad to contribute to this amazing repo 😄

@Snailedlt
Copy link
Owner

@Zingzy I'm glad you enjoy it!
Thank you for the contribution, always enjoyable to review when everything is this tidy! 😊

Feel free to make issues or PRs if you find anything more that can be improved or fixed :)

@Zingzy
Copy link
Contributor Author

Zingzy commented Oct 7, 2024

@Zingzy I'm glad you enjoy it! Thank you for the contribution, always enjoyable to review when everything is this tidy! 😊

Feel free to make issues or PRs if you find anything more that can be improved or fixed :)

Thank you, I would also love to contribute to issue #11 😊

@Snailedlt
Copy link
Owner

@Zingzy awesome!
Feel free to work with any issue you'd like 😊
I assigned #11 to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants