Use a wrapper type implementing Sync, instead of static mut
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 75.34% 76.16% +0.82%
==========================================
Files 48 45 -3
Lines 8257 8153 -104
==========================================
- Hits 6221 6210 -11
+ Misses 2036 1943 -93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Re-ran CI so it would use the new nightly, and everything passes. |
elinorbgr
reviewed
Feb 23, 2024
|
Could you just add a changelog entry for the scanner for this? AFAICT this is not a breaking change, but it's still noteworthy imo. |
`static mut` is generally best avoided. It seems to only be necessary currently to allow the use of non-`Sync` types, since pointers are not sync. This also removes the `NULLPTR` constant in favor of using `std::ptr::null`, uses `.as_ptr()` instead of casting, and uses the arrray repeating syntax to define `types_null`. None of those should impact behavior or the public API. `*_requests` and `*_events` static are no longer public now. This is theoretically a breaking change, but shouldn't really impact anything.
ids1024
force-pushed
the
no-static-mut
branch
2 times, most recently
from
003ac2c to
ee7e346
Compare
|
Mentioned in changelog, and fixed more CI warnings. |
Decodetalkers
pushed a commit
to Decodetalkers/wayland-rs
that referenced
this pull request
Apr 26, 2024
…hay#700) * Use a wrapper type implementing `Sync`, instead of `static mut` `static mut` is generally best avoided. It seems to only be necessary currently to allow the use of non-`Sync` types, since pointers are not sync. This also removes the `NULLPTR` constant in favor of using `std::ptr::null`, uses `.as_ptr()` instead of casting, and uses the arrray repeating syntax to define `types_null`. None of those should impact behavior or the public API. `*_requests` and `*_events` static are no longer public now. This is theoretically a breaking change, but shouldn't really impact anything. * Suppress `clippy::test_attr_in_doctest` lint * Address nightly warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static mutis generally best avoided. It seems to only be necessary currently to allow the use of non-Synctypes, since pointers are not sync.This also removes the
NULLPTRconstant in favor of usingstd::ptr::null, uses.as_ptr()instead of casting, and uses the arrray repeating syntax to definetypes_null. None of those should impact behavior or the public API.*_requestsand*_eventsstatic are no longer public now. This is theoretically a breaking change, but shouldn't really impact anything.