Don't try to connect to empty WAYLAND_SOCKET

[kchibisov]

--

I basically moved code around so it looks a bit nicer.

[kchibisov]

The thing about it is that libwayland is not really doing that sort of stuff and empty WAYLAND_SOCKET will still prevent it from running.

So maybe all of that is actually intended?

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eb7a57b) 75.34% compared to head (d0cb59e) 76.27%.

Files	Patch %	Lines
wayland-client/src/conn.rs	90.32%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   75.34%   76.27%   +0.93%     
==========================================
  Files          48       45       -3     
  Lines        8257     8161      -96     
==========================================
+ Hits         6221     6225       +4     
+ Misses       2036     1936     -100     

Flag	Coverage Δ
main	59.09% <0.00%> (+0.72%)	⬆️
test--	81.22% <90.32%> (+0.14%)	⬆️
test--server_system	64.70% <90.32%> (+0.19%)	⬆️
test-client_system-	72.32% <90.32%> (+0.17%)	⬆️
test-client_system-server_system	55.01% <90.32%> (+0.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[i509VCB]

The thing about it is that libwayland is not really doing that sort of stuff and empty WAYLAND_SOCKET will still prevent it from running.

So maybe all of that is actually intended?

Probably worth an issue upstream with libwayland

[kchibisov]

https://gitlab.freedesktop.org/wayland/wayland/-/issues/438

[elinorbgr]

I guess we will keep following upstream behaviour on this one, for consistency.