backend: Use Buffer<u8> instead of Buffer<u32> #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
==========================================
- Coverage 73.03% 73.00% -0.04%
==========================================
Files 48 48
Lines 7841 7826 -15
==========================================
- Hits 5727 5713 -14
+ Misses 2114 2113 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
That looks pretty clean overall, is there something you want to change, given you've set this PR as a draft? |
Both are documented as wrappers around `memmove`. But this one is safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think
sendmsg/recvmsgare necessarily guaranteed to read/write a multiple of 4 bytes, so for correctness we need to buffer bytes rather than words. This also avoids unsafe casts.This is based on #666. Not sure if the helpers here for reading/writing words to the buffer could be improved. Perhaps as methods of
Buffer, if that's only being used for this.This doesn't seem particularly worse to handle than the previous way, since either version has to deal with lengths in bytes vs. words, and array padding.