Log requests on dead objects #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it possible to understand that something got discarded, print a message saying so inside when `WAYLAND_DEBUG` is enabled. This also changes how timestamps are computed for `WAYLAND_DEBUG` log so they align with `libwayland-client` to look into logs using both at the same time more accessible. The `[rs]` particle was added to the log to give a hint which library was used, which could be helpful when looking into random logs.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 73.31% 73.25% -0.07%
==========================================
Files 47 48 +1
Lines 7847 7862 +15
==========================================
+ Hits 5753 5759 +6
- Misses 2094 2103 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it possible to understand that something got discarded, print a message saying so inside when
WAYLAND_DEBUGis enabled.This also changes how timestamps are computed for
WAYLAND_DEBUGlog so they align withlibwayland-clientto look into logs using both at the same time more accessible. The[rs]particle was added to the log to give a hint which library was used, which could be helpful when looking into random logs.