-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port from nix to rustix #658
Conversation
See bytecodealliance/rustix#851 for |
35946e2
to
d5df48c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 73.02% 73.16% +0.13%
==========================================
Files 47 47
Lines 7779 7795 +16
==========================================
+ Hits 5681 5703 +22
+ Misses 2098 2092 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Now this just needs bytecodealliance/rustix#851 to be merged and released, and I guess I need to test on a BSD to update the kqueue code. |
1c45163
to
d75c73a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why libc
was added here, it seems to me it could be dropped entirely.
(despite the fact it's still in the dependency tree of course)
0a63cfc
to
6d8b721
Compare
#653
Incomplete. Looks like
rustix
needs support forSO_PEERCRED
.