Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from nix to rustix #658

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Port from nix to rustix #658

merged 1 commit into from
Oct 31, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Sep 23, 2023

#653

Incomplete. Looks like rustix needs support for SO_PEERCRED.

@ids1024
Copy link
Member Author

ids1024 commented Sep 26, 2023

See bytecodealliance/rustix#851 for SO_PEERCRED.

@ids1024 ids1024 force-pushed the rustix branch 3 times, most recently from 35946e2 to d5df48c Compare October 4, 2023 04:34
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (8581b9d) 73.02% compared to head (a96ce07) 73.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   73.02%   73.16%   +0.13%     
==========================================
  Files          47       47              
  Lines        7779     7795      +16     
==========================================
+ Hits         5681     5703      +22     
+ Misses       2098     2092       -6     
Flag Coverage Δ
main 58.48% <63.21%> (+0.13%) ⬆️
test-- 78.26% <93.24%> (?)
test--server_system 61.43% <44.59%> (+0.08%) ⬆️
test-client_system- 69.12% <84.00%> (+0.02%) ⬆️
test-client_system-server_system 51.38% <17.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wayland-backend/src/rs/server_impl/client.rs 75.40% <100.00%> (ø)
wayland-backend/src/rs/server_impl/common_poll.rs 86.82% <100.00%> (ø)
wayland-backend/src/rs/server_impl/handle.rs 69.46% <100.00%> (+0.41%) ⬆️
wayland-backend/src/sys/client_impl/mod.rs 71.32% <100.00%> (ø)
wayland-server/src/socket.rs 45.55% <100.00%> (ø)
wayland-client/src/conn.rs 85.03% <91.66%> (+1.16%) ⬆️
wayland-client/src/event_queue.rs 58.40% <0.00%> (ø)
wayland-backend/src/rs/socket.rs 93.44% <92.30%> (+3.66%) ⬆️
wayland-cursor/src/lib.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ids1024
Copy link
Member Author

ids1024 commented Oct 4, 2023

Now this just needs bytecodealliance/rustix#851 to be merged and released, and I guess I need to test on a BSD to update the kqueue code.

@ids1024 ids1024 force-pushed the rustix branch 4 times, most recently from 1c45163 to d75c73a Compare October 4, 2023 22:37
@ids1024 ids1024 changed the title WIP port from nix to rustix Port from nix to rustix Oct 4, 2023
@ids1024 ids1024 marked this pull request as ready for review October 4, 2023 22:59
Copy link
Contributor

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why libc was added here, it seems to me it could be dropped entirely.
(despite the fact it's still in the dependency tree of course)

wayland-backend/src/rs/socket.rs Outdated Show resolved Hide resolved
wayland-backend/src/types/server.rs Outdated Show resolved Hide resolved
@ids1024 ids1024 force-pushed the rustix branch 2 times, most recently from 0a63cfc to 6d8b721 Compare October 6, 2023 19:45
@elinorbgr elinorbgr merged commit edd0f60 into Smithay:master Oct 31, 2023
15 checks passed
@ids1024 ids1024 mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants