anvil: fix vulkan fifo mode #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limiting the commit timer to the primary output might result in a one frame de-sync between outputs with very similar output refreshes. this is especially noticeable on when showing the same client buffer across multiple gen-locked outputs.
the presentation feedback is calculated using the primary scan-out output, so we have to make sure we have the correct one to not introduce an unnecessary delay during client startup and output migration.
commit timing aware clients will use timestamps based on the refresh received through the presentation feedback. we have to use the same precision when calculating the frame target for signaling the commit timer. for example mesa vk will subtract 500us from the estimated vsync when setting the commit timer timestamp. rounding to millisecond precision will break this logic.
Drakulix
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally makes vulkan fifo mode work correctly on anvil.
Tested with
vkmark -p fifowhich now outputs steady 60fps on my laptop.closes #1583