xdg: Add getters for pending configures and current state serial #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pending configures are useful for when you need to check the state that you sent to the client, but that it hadn't acknowledged yet, along with their serials. I only expose read access so that you can't mess with the internal commit tracking.
The serials in general (like the current state serial) are useful in case you want to synchronize something to surface commits. The case I have in niri is that I want to know if the surface had already committed the state that it had last acked, or not yet. Specifically, for the surface size, I want to differentiate between when the surface acked a new size and hasn't committed in response yet, and when the surface acked a new size but committed a different size in response.