Update to pixman 0.2, and make PixmanTexture thread-safe
#1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
pixman-send
branch
3 times, most recently
from
582b9ee to
0057af0
Compare
|
I think if the pixman-rs PR is merged and released, everything here is good. |
|
|
Enable the new `sync` feature to make `pixman::Image` `Send`/`Sync`. The new `pixman` version also makes various methods take `&mut`, so this updates things to use mutable references where needed. This changes some `borrow()` calls to `borrow_mut()`, but looks like it shouldn't cause double borrows.
It is no more unsafe to access this in multiple threads than in one. The caller should assume another process may be mutating the buffer.
Allows `PixmanImage` to be sent to another thread.
ids1024
changed the title
Sendpixman 0.2, and make PixmanTexture thread-safe
Drakulix
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing. Compiles, but I haven't checked that the
borrow_mutcalls can't panic.Requires cmeissl/pixman-rs#19.