Support fifo-v1 and commit-timing-v1 protocol #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissl
force-pushed
the
feature/fifo_v1
branch
from
ee4acc9 to
9e6d071
Compare
cmeissl
commented
Nov 14, 2024
cmeissl
commented
Nov 14, 2024
| } | ||
|
|
||
| if let Some(barrier) = into.barrier.replace(barrier) { | ||
| barrier.signal(); |
There was a problem hiding this comment.
I tried to come up with a reason why this might be problematic, but so far couldn't find one.
cmeissl
force-pushed
the
feature/fifo_v1
branch
2 times, most recently
from
781d84f to
6f358d4
Compare
cmeissl
changed the title
cmeissl
force-pushed
the
feature/fifo_v1
branch
4 times, most recently
from
b899004 to
467a82f
Compare
Drakulix
reviewed
Nov 18, 2024
At commit time we might not know and the protocol only says may. What I did in anvil is that a blocker will be cleared if the processed output matches the primary output or if the surface does not have a primary output. imo the main reason for having this written in the spec is to allow a client make forward progress instead of being blocked indefinitely with frame callbacks. |
cmeissl
force-pushed
the
feature/fifo_v1
branch
from
467a82f to
6d3f291
Compare
cmeissl
force-pushed
the
feature/fifo_v1
branch
from
6d3f291 to
8f4034a
Compare
and while at it resolve the long standing issue that anvil does not send frame callbacks for cursor and dnd surfaces
cmeissl
force-pushed
the
feature/fifo_v1
branch
from
8f4034a to
c870be3
Compare
Drakulix
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the new fifo and commit timing protocol and changes for wp-presentation version 2
Clearing barriers needs to be better abstracted/helpers are needed
The integration in anvil for clearing fifo barriers is just bare bones. We probably wantto provide something similar like we already do for
send_framesand so.Also it is incomplete atm, we also need to clear blockers for offscreen/non visible surfaces and so on.
Actually it might be a good start as is, we can clear some blockers directly while figuring out the primary scan-out output.
Can we do better than using an idle task for calling
blocker_cleared?This might be anvil specifc, but I am actually not sure. callingblocker_clearedneeds the client state and wealso have to provide the compositor state. this makes it hard to call from within a nested function inside the state
like the render function in anvil. For now I just worked around this by scheduling an idle task...
Yes, I refactored
post_commitand it can now use the state. In addition it also de-duplicatesblocker_clearedper client.Testing
I pushed a simple test client here.
closes #1581
closes #1582