Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenericWindow #1233

Closed
wants to merge 0 commits into from
Closed

Add GenericWindow #1233

wants to merge 0 commits into from

Conversation

saihaze
Copy link
Contributor

@saihaze saihaze commented Nov 22, 2023

GenericWindow is added to abstract over both Wayland and X11 windows.
Some comments are copied from Window.
Anvil hasn't been modified yet. It's WIP.

@saihaze saihaze marked this pull request as ready for review November 24, 2023 06:49
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

Attention: 271 lines in your changes are missing coverage. Please review.

Comparison is base (859ed44) 21.74% compared to head (11ea062) 21.91%.

Files Patch % Lines
src/desktop/wayland/generic_window.rs 38.52% 217 Missing ⚠️
anvil/src/shell/element.rs 37.50% 40 Missing ⚠️
anvil/src/shell/ssd.rs 0.00% 7 Missing ⚠️
anvil/src/shell/grabs.rs 0.00% 4 Missing ⚠️
anvil/src/input_handler.rs 0.00% 2 Missing ⚠️
anvil/src/focus.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
+ Coverage   21.74%   21.91%   +0.17%     
==========================================
  Files         155      156       +1     
  Lines       24451    24626     +175     
==========================================
+ Hits         5316     5398      +82     
- Misses      19135    19228      +93     
Flag Coverage Δ
wlcs-buffer 18.85% <27.16%> (+0.08%) ⬆️
wlcs-core 18.52% <28.99%> (+0.09%) ⬆️
wlcs-output 7.60% <0.00%> (-0.06%) ⬇️
wlcs-pointer-input 20.69% <36.30%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saihaze
Copy link
Contributor Author

saihaze commented Nov 26, 2023

Related to #1202

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite useful already!

anvil/src/shell/element.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants