wayland(dmabuf): ImportNotifier for asynchronous buffer import #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
force-pushed
the
dmabuf-import-notifier
branch
from
c66db18 to
b1ecb8e
Compare
i509VCB
force-pushed
the
dmabuf-import-notifier
branch
from
b1ecb8e to
283524b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
+ Coverage 19.38% 21.71% +2.32%
==========================================
Files 154 155 +1
Lines 24099 24431 +332
==========================================
+ Hits 4672 5305 +633
+ Misses 19427 19126 -301
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Drakulix
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ImportNotifier type, which allows dmabuf import results to be delayed until processed at a later time. In my case this would be after being handled through a channel but can be extended to allow creating an importing thread.
Resolves #699
A quick test by smalling alacritty in smallvil shows this appears to work correctly.