-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyboard: allow setting keymap directly #1218
Conversation
Also make the Layout.0 public to allow constructing Layouts from u32s.
To be clear: I don't oppose this change. |
A passthrough compositor. In the wayland client part of my code, I'm getting the keymap as a string/file descriptor and the layout index from update_modifiers (Smithay/client-toolkit#430 for that), and need to pass that information on to clients running against my compositor. So I have the full keymap file and can construct a Keymap, but I don't have the RMLVO string which is what compositors usually construct a keymap from. |
#750 has something similar. But I noticed the API is potentially unsound since |
I can modify this api to accept a String instead and construct the keymap inside set_keymap with Keymap::new_from_string (that's how I'm constructing the Keymap outside the function currently). I'll send a pr for that in a few min. |
Fixes soundness issue introduced in Smithay#1218.
#1221 for that change. Thanks for catching that. |
Fixes soundness issue introduced in #1218.
Fixes soundness issue introduced in Smithay#1218.
Fixes soundness issue introduced in Smithay#1218.
Also make the Layout.0 public to allow constructing Layouts from u32s.