Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clippy to disallow e/print/ln macros #1213

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

SpyrosRoum
Copy link
Contributor

closes #1034

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd0bb24) 21.99% compared to head (581b14b) 21.99%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1213   +/-   ##
=======================================
  Coverage   21.99%   21.99%           
=======================================
  Files         154      154           
  Lines       24112    24112           
=======================================
  Hits         5303     5303           
  Misses      18809    18809           
Flag Coverage Δ
wlcs-buffer 18.99% <ø> (ø)
wlcs-core 18.67% <ø> (ø)
wlcs-output 7.75% <ø> (ø)
wlcs-pointer-input 20.83% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
build.rs 80.72% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpyrosRoum
Copy link
Contributor Author

Didn't realize clippy runs with the top level config for anvil and smallvil.

I will switch print to tracing logs for those as part of this PR.

@SpyrosRoum SpyrosRoum force-pushed the chore/block-print-macros branch from 581b14b to b5e0bc8 Compare November 8, 2023 09:08
@SpyrosRoum
Copy link
Contributor Author

Ended up allowing print for usage messages in smallvil, I think it makes more sense to print help messages like that.

However if you think I should change them to tracing logs let me know

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. :)

@Drakulix Drakulix merged commit 5c656cc into Smithay:master Nov 8, 2023
13 checks passed
@SpyrosRoum SpyrosRoum deleted the chore/block-print-macros branch November 8, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure clippy::disallowed_macros
3 participants