Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backend/x11/mod docs #1211

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

SpyrosRoum
Copy link
Contributor

The documentation claims that X11Backend::new returns both X11Backend and X11Surface, but there is not X11Surface returned

The documentation claims that X11Backend::new returns both X11Backend
and X11Surface, but there is not X11Surface returned
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks :)

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd0bb24) 21.99% compared to head (fd351ef) 22.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   21.99%   22.00%   +0.01%     
==========================================
  Files         154      154              
  Lines       24112    24112              
==========================================
+ Hits         5303     5306       +3     
+ Misses      18809    18806       -3     
Flag Coverage Δ
wlcs-buffer 18.99% <ø> (ø)
wlcs-core 18.67% <ø> (ø)
wlcs-output 7.75% <ø> (ø)
wlcs-pointer-input 20.84% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Drakulix Drakulix merged commit 0716691 into Smithay:master Nov 7, 2023
13 checks passed
@SpyrosRoum SpyrosRoum deleted the docs/correct-x11-module branch November 7, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants