Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd: include missing libc crate #205

Merged
merged 1 commit into from
Oct 24, 2024
Merged

freebsd: include missing libc crate #205

merged 1 commit into from
Oct 24, 2024

Conversation

Drakulix
Copy link
Member

This causes compilation issues with the libc references in the devname_r definition in the devname function. With this compiling on freebsd succeeds.

Also make the non-linux versions of dev_path public, so other OS types can call it.

This causes compilation issues with the libc references in the
devname_r definition in the devname function. With this compiling
on freebsd succeeds.

Also make the non-linux versions of dev_path public, so other OS
types can call it.
@Drakulix
Copy link
Member Author

@amshafer Given this is an edition 2021 crate, we shouldn't need the extern crate and yes, I would like to limit the dependency to freebsd.

I pushed a new commit, that should already include all these changes, can you confirm, that this also fixes the problem for you? cargo check --target x86_64-unknown-freebsd seems to agree on my system, but I don't wanna setup a cross-compiler or VM or properly test this small change, if not necessary.

If so, I can merge this and do a patch release quickly.

@amshafer
Copy link
Contributor

Thanks, can confirm this does still fix the issue.

@Drakulix Drakulix merged commit 6683a81 into develop Oct 24, 2024
17 checks passed
@Drakulix Drakulix deleted the freebsd-fix branch October 24, 2024 16:02
@Drakulix
Copy link
Member Author

Should be published as 0.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants