Ensure FIPS compliance by marking MD5 and SHA-1 as non-security-related #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses issues with environments that enforce FIPS standards by preventing non-compliant algorithms (like MD5 and SHA-1) from being used in contexts related to security. Since these hashes do not involve sensitive data they should be explicitly marked as not used for security.
The easiest syntax change would be to just add a kwarg to calls.
short_sha = hashlib.sha1(parts.encode('utf-8', usedforsecurity=False))
Unfortunately that's not compatible with Python <3.9.
Alternative solution to this problem could be switching to sha-256 hashes everywhere.
Alternative implementation could be:
Context:
python/cpython#53462 (comment)