Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzers #2

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Fix analyzers #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ec7fd0
Fix analyzers
Smaug123 Jan 23, 2024
18b3380
Maybe
Smaug123 Jan 23, 2024
936c9e0
I hate the dotnet cli
Smaug123 Jan 23, 2024
348c0c8
Merge branch 'main' into fix-analyzers
Smaug123 Jan 30, 2024
bd2ee90
Bump analysers
Smaug123 Jan 30, 2024
7c415c7
Fix again
Smaug123 Jan 30, 2024
3111962
Fix again
Smaug123 Jan 30, 2024
ebf4fa2
Surely this can't be the difference
Smaug123 Jan 30, 2024
ba5b4a8
Bump .NET SDK
Smaug123 Jan 30, 2024
3b16b11
Bump
Smaug123 Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
]
},
"fsharp-analyzers": {
"version": "0.23.0",
"version": "0.24.0",
"commands": [
"fsharp-analyzers"
]
}
}
}
}
4 changes: 2 additions & 2 deletions .github/workflows/dotnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ jobs:
- name: Prepare analyzers
run: nix develop --command dotnet restore analyzers/analyzers.fsproj
- name: Build project
run: nix develop --command dotnet build
run: nix develop --command dotnet build ./PrattParser/PrattParser.fsproj
- name: Run analyzers
run: nix run .#fsharp-analyzers -- --project ./PrattParser/PrattParser.fsproj --analyzers-path ./.analyzerpackages/g-research.fsharp.analyzers/0.6.0/ --verbosity detailed --report ./analysis.sarif --treat-as-error GRA-STRING-001 GRA-STRING-002 GRA-STRING-003 GRA-UNIONCASE-001 GRA-INTERPOLATED-001 GRA-TYPE-ANNOTATE-001 GRA-VIRTUALCALL-001 GRA-IMMUTABLECOLLECTIONEQUALITY-001 GRA-JSONOPTS-001 GRA-LOGARGFUNCFULLAPP-001
run: nix run .#fsharp-analyzers -- --project ./PrattParser/PrattParser.fsproj --analyzers-path ./.analyzerpackages/g-research.fsharp.analyzers/0.8.0/ --verbosity detailed --report ./analysis.sarif --treat-as-error GRA-STRING-001 GRA-STRING-002 GRA-STRING-003 GRA-UNIONCASE-001 GRA-INTERPOLATED-001 GRA-TYPE-ANNOTATE-001 GRA-VIRTUALCALL-001 GRA-IMMUTABLECOLLECTIONEQUALITY-001 GRA-JSONOPTS-001 GRA-LOGARGFUNCFULLAPP-001

build-nix:
runs-on: ubuntu-latest
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ riderModule.iml
*.sarif

result
analysis.sarif
.analyzerpackages/
2 changes: 1 addition & 1 deletion analyzers/analyzers.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageDownload Include="G-Research.FSharp.Analyzers" Version="[0.6.0]" />
<PackageDownload Include="G-Research.FSharp.Analyzers" Version="[0.8.0]" />
</ItemGroup>

</Project>
12 changes: 6 additions & 6 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"sdk": {
"version": "8.0.100",
"rollForward": "latestFeature"
}
}
Loading