Fix slow rendering of catalog filter #1025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastislav-chynoransky
changed the title
rastislav-chynoransky
force-pushed
the
WEBUMENIA-2095
branch
from
d30520c
to
f143494
Compare
FrantisekMichalSebestyen
requested changes
Sep 30, 2024
There was a problem hiding this comment.
The popover closes on mouseover outside of container:
https://github.com/user-attachments/assets/384e97d3-8f65-451e-997e-0217391c6298
caused by using VMenu instead of VDropdown. This is by the behaviour of the component. Fixed with c96b275 |
igor-kamil
reviewed
Nov 21, 2024
|
@igor-kamil how is the feel of it though? on my machine it's a visible improvement. maybe on your machine there's no significant delay in both cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.sng.sk/browse/WEBUMENIA-2095
Measuring performance of scripting/rendering we were able to speed up the response time by ~300ms (30%).
before:
after:
