Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api] Hologram Service Update #4255

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[Api] Hologram Service Update #4255

wants to merge 6 commits into from

Conversation

JustAHuman-xD
Copy link
Contributor

Description

There are a number of known issues with the current Hologram Service as well as a few that I found while making this PR.
I'm making this PR to update the hologram service to use text displays in 1.19.4+ and to just revamp the outdated system.
Replaces #4197

Proposed changes

I need to fill this, there is a lot<

Related Issues (if applicable)

#3176

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@JustAHuman-xD JustAHuman-xD requested a review from a team as a code owner November 2, 2024 01:52
@github-actions github-actions bot added the 🔧 API This Pull Request introduces API changes. label Nov 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Your Pull Request was automatically labelled as: "🔧 API"
Thank you for contributing to this project! ❤️

@JustAHuman-xD JustAHuman-xD marked this pull request as draft November 2, 2024 01:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 5af1692

https://preview-builds.walshy.dev/download/Slimefun/4255/5af1692b

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Intybyte
Intybyte reviewed Nov 2, 2024
View reviewed changes
src/main/resources/languages/en/messages.yml
@@ -316,6 +316,7 @@ machines:
HOLOGRAM_PROJECTOR:
enter-text: '&7Please enter your desired Hologram Text into your Chat. &r(Color Codes are supported!)'
inventory-title: 'Hologram Editor'
broken: '&cThe Hologram Projector you were editing has been broken, your message has been ignored.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that a new translation key is needed here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intybyte Intybyte Intybyte left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
🔧 API This Pull Request introduces API changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustAHuman-xD @Intybyte