-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new ItemStack => ItemStack.of #4246
base: walshy/mc-1.21
Are you sure you want to change the base?
new ItemStack => ItemStack.of #4246
Conversation
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would break backward compatibility, add version check
i completely forgot about that, on it |
Applied to everything beside test enviroment for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe it is better if I move the StackResolver to the |
Running with a local fork of MockBukkit |
ba1a765
to
f5c1482
Compare
afaf3aa
to
c84e876
Compare
…ks-of # Conflicts: # pom.xml # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/tools/ExplosiveTool.java
Description
Use
ItemStack.of
instead ofnew ItemStack
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values