Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix compilation error due to DirectionType redifinition #2

Conversation

@Sunderlandkyl
Copy link

Thanks!

@gregsharp
Copy link
Member

Thanks Michael. Is there an easy way for me to merge this into the gitlab repo?

@MichaelColonel
Copy link
Author

I will make a PR into gitlab repository.

@MichaelColonel
Copy link
Author

@gregsharp

Merge request in gitlab

@gregsharp
Copy link
Member

Unfortunately this breaks CUDA. I will work on an alternate solution.

@gregsharp
Copy link
Member

Apparently I cannot re-open an issue that I didn't create. But please consider it to be re-opened.

@MichaelColonel
Copy link
Author

I can't re-open it, but i can create a new pull request to revert these changes.

@gregsharp
Copy link
Member

gregsharp commented Nov 1, 2022

I have a new fix for this in 753f6ad and eeb0884. Can you check if this will work?

How can I easily make a pull request from gitlab?

@gregsharp
Copy link
Member

I think there is no need to revert, I merged yours, this will update from there.

@MichaelColonel
Copy link
Author

MichaelColonel commented Nov 2, 2022

I've checked gitlab updates, and both SlicerRT and Plastimatch were compiled successfully.
Tests are OK too.

@MichaelColonel
Copy link
Author

Update: I've only tested in Linux, and i don't have CUDA.

@MichaelColonel
Copy link
Author

How can I easily make a pull request from gitlab?

I've cherry picked these two cuda commits, and i will try to create a pull request, and eventually update SlicerRT Plastimatch cmake file.

@MichaelColonel
Copy link
Author

@gregsharp Could you check that #3 is OK, and my cherry picking is correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants