network/nordvpn: Fixed compatibility issues #8753

RezaT4795 · 2024-11-15T22:39:17Z

No description provided.

github-actions · 2024-11-15T22:39:59Z

reverse dependencies - network/nordvpn

None

github-actions · 2024-11-15T22:40:12Z

✅ sbolint - network/nordvpn ✅

sbolint: nordvpn checks out OK

aclemons · 2024-11-16T00:55:10Z

network/nordvpn/doinst.sh

+# Patched by Peter Christy <[email protected]>
+
+# update configuration and shared library cache for linker to find .so files
+echo "/usr/lib64/nordvpn" > /etc/ld.so.conf.d/nordvpn.conf


The info file has a download for both 32 and 64bit. But this is hardcoded to lib64?

aclemons · 2024-11-16T00:55:19Z

network/nordvpn/nordvpn.SlackBuild

@@ -88,6 +90,12 @@ mkdir -p $PRGNAM-$VERSION
 cd $PKG
 ar p $CWD/${PRGNAM}_${VERSION}_${DEBARCH}.deb data.tar.gz | tar zxv

+# nordvpn-3.19.x appears to need additional libraries:
+mkdir -p usr/lib64/nordvpn


Here also lib64

network/nordvpn/nordvpn.SlackBuild

willysr

please have a look on the comments

noisecode3 · 2024-11-18T17:22:01Z

There might be binary helper programs in there for the app to fully function. Or I did it wrong. But I read about them, they should be used by the main program?

edit: yes I was wrong the app should know the path to those and they should not be exposed to the users, btw there was an update now its 3.19.1 lol.

willysr · 2024-11-20T03:08:45Z

@RezaT4795 ?

RezaT4795 · 2024-11-20T08:30:55Z

@willysr I should fix the issues and test it properly, but I cannot right now. Iwill make new changes this weekend. Please keep this PR open if possible.

Signed-off-by: Reza Talebi <[email protected]>

RezaT4795 · 2024-11-23T21:54:03Z

@willysr @aclemons Sorry for the delay. Hope this is ok now.

willysr · 2024-11-24T10:10:15Z

@sbo-bot: build network/nordvpn

sbo-bot · 2024-11-24T10:24:53Z

buildpkg i586 network/nordvpn

Creating hintfile directory: /etc/repo/SBo/hintfiles
Checking whether git is clean ... yes.
Indexing SlackBuilds ... done.
git repo: /var/lib/repo/SBo/slackbuilds
branch:   HEAD
date:     Sat Nov 23 21:52:54 GMT 2024
revision: 4b4845cc9fa7b10cc4a16da36c778f5810bc168f
title:    Merge 86f0a8e5619cc263bc25cdcf1d1b2aba0a852c12 into 87bac936d42f062af2cf6ee60452c6b40fc79165

================================================================================
network/nordvpn                                                         10:24:22
================================================================================

Calculating dependencies ... 
Hints for network/nordvpn:
  GROUPADD="373:nordvpn"

Building network/nordvpn (update for version 3.19.1) ------------------ 10:24:22
Testing SlackBuild files ... done.
Downloading source files ...
Verifying source files ... done.
Adding groups and users:
  groupadd -g 373 nordvpn; 
Running nordvpn.SlackBuild ...                                      ETA 10:25:??
env MAKEFLAGS='-j24 -l13' nice -n 5 bash ./nordvpn.SlackBuild
network/nordvpn: nordvpn.SlackBuild failed (status 1)                   10:24:34
See /var/log/repo/SBo/network/nordvpn/build.log
Unmounting chroot ... done.
⛔️ network/nordvpn FAILED ⛔️

================================================================================
SUMMARY                                                                 10:24:35
================================================================================

Logfile:     /var/log/repo/SBo/repo_2024-11-24_10:24:21.log
Runtime:     0h 0m 14s
Failed:      1
  network/nordvpn

Snipped Build Failure

Building network/nordvpn (update for version 3.19.1) 2024-11-24 10:24:22
Testing SlackBuild files ... 
Downloading source files ...
Verifying source files ... 
Adding groups and users:
  groupadd -g 373 nordvpn; 
Running nordvpn.SlackBuild ...                                      ETA 10:25:??
env MAKEFLAGS='-j24 -l13' nice -n 5 bash ./nordvpn.SlackBuild
./etc/
./etc/init.d/
./etc/init.d/nordvpn
./usr/
./usr/bin/
./usr/bin/nordvpn
./usr/lib/
./usr/lib/nordvpn/
./usr/lib/nordvpn/libmoosenordvpnapp.so
./usr/lib/nordvpn/libmooseworker.so
./usr/lib/nordvpn/libnorddrop.so
./usr/lib/nordvpn/libsqlite3.so
./usr/lib/nordvpn/libtelio.so
./usr/lib/nordvpn/nordfileshare
./usr/lib/nordvpn/norduserd
./usr/lib/nordvpn/openvpn
./usr/lib/systemd/
./usr/lib/systemd/system/
./usr/lib/systemd/system/nordvpn.service
./usr/lib/systemd/system/nordvpnd.service
./usr/lib/systemd/system/nordvpnd.socket
./usr/lib/tmpfiles.d/
./usr/lib/tmpfiles.d/nordvpn.conf
./usr/sbin/
./usr/sbin/nordvpnd
./usr/share/
./usr/share/applications/
./usr/share/applications/nordvpn.desktop
./usr/share/bash-completion/
./usr/share/bash-completion/completions/
./usr/share/bash-completion/completions/nordvpn
./usr/share/doc/
./usr/share/doc/nordvpn/
./usr/share/doc/nordvpn/changelog.Debian.gz
./usr/share/icons/
./usr/share/icons/hicolor/
./usr/share/icons/hicolor/scalable/
./usr/share/icons/hicolor/scalable/apps/
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-black.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-blue.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-gray.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-white.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn.svg
./usr/share/licenses/
./usr/share/licenses/nordvpn/
./usr/share/licenses/nordvpn/LICENSE.md
./usr/share/licenses/nordvpn/THIRD-PARTY-NOTICES.md
./usr/share/man/
./usr/share/man/man1/
./usr/share/man/man1/nordvpn.1.gz
./usr/share/zsh/
./usr/share/zsh/functions/
./usr/share/zsh/functions/Completion/
./usr/share/zsh/functions/Completion/Unix/
./usr/share/zsh/functions/Completion/Unix/_nordvpn_auto_complete
./var/
./var/lib/
./var/lib/nordvpn/
./var/lib/nordvpn/data/
./var/lib/nordvpn/data/countries.dat
./var/lib/nordvpn/data/cybersec.dat
./var/lib/nordvpn/data/insights.dat
./var/lib/nordvpn/data/ovpn_template.xslt
./var/lib/nordvpn/data/ovpn_xor_template.xslt
./var/lib/nordvpn/data/servers.dat
cp: 'usr/lib/nordvpn/libmoosenordvpnapp.so' and 'usr/lib/nordvpn/libmoosenordvpnapp.so' are the same file
cp: 'usr/lib/nordvpn/libmooseworker.so' and 'usr/lib/nordvpn/libmooseworker.so' are the same file
cp: 'usr/lib/nordvpn/libnorddrop.so' and 'usr/lib/nordvpn/libnorddrop.so' are the same file
cp: 'usr/lib/nordvpn/libsqlite3.so' and 'usr/lib/nordvpn/libsqlite3.so' are the same file
cp: 'usr/lib/nordvpn/libtelio.so' and 'usr/lib/nordvpn/libtelio.so' are the same file
network/nordvpn: nordvpn.SlackBuild failed (status 1)                   10:24:34
Unmounting chroot ... 
:-( network/nordvpn FAILED )-:

sbo-bot · 2024-11-24T10:26:29Z

buildpkg x86_64 network/nordvpn

Creating hintfile directory: /etc/repo/SBo/hintfiles
Checking whether git is clean ... yes.
Indexing SlackBuilds ... done.
git repo: /var/lib/repo/SBo/slackbuilds
branch:   HEAD
date:     Sat Nov 23 21:52:54 GMT 2024
revision: 4b4845cc9fa7b10cc4a16da36c778f5810bc168f
title:    Merge 86f0a8e5619cc263bc25cdcf1d1b2aba0a852c12 into 87bac936d42f062af2cf6ee60452c6b40fc79165

================================================================================
network/nordvpn                                                         10:25:32
================================================================================

Calculating dependencies ... 
Hints for network/nordvpn:
  GROUPADD="373:nordvpn"

Building network/nordvpn (update for version 3.19.1) ------------------ 10:25:32
Testing SlackBuild files ... done.
Downloading source files ...
Verifying source files ... done.
Adding groups and users:
  groupadd -g 373 nordvpn; 
Running nordvpn.SlackBuild ...                                      ETA 10:26:??
env MAKEFLAGS='-j24 -l13' nice -n 5 bash ./nordvpn.SlackBuild
Built ok:  nordvpn-3.19.1-x86_64-1_SBo.txz                              10:25:57
Testing package nordvpn-3.19.1-x86_64-1_SBo.txz ... done.
Test installing nordvpn-3.19.1-x86_64-1_SBo.txz ...
Adding groups and users:
  groupadd -g 373 nordvpn; 
groupadd: group 'nordvpn' already exists
nordvpn-3.19.1-x86_64-1_SBo: Protect your privacy online. .............. [  60M]
Unmounting chroot ... done.
Backed up: nordvpn-3.19.0-x86_64-2_SBo.txz
✅ network/nordvpn Updated for version 3.19.1 ✅

================================================================================
SUMMARY                                                                 10:26:04
================================================================================

Logfile:     /var/log/repo/SBo/repo_2024-11-24_10:25:31.log
Runtime:     0h 0m 33s
Updated:     1
  network/nordvpn/nordvpn-3.19.1-x86_64-1_SBo.txz

Snipped Build Log

Building network/nordvpn (update for version 3.19.1) 2024-11-24 10:25:32
Testing SlackBuild files ... 
Downloading source files ...
Verifying source files ... 
Adding groups and users:
  groupadd -g 373 nordvpn; 
Running nordvpn.SlackBuild ...                                      ETA 10:26:??
env MAKEFLAGS='-j24 -l13' nice -n 5 bash ./nordvpn.SlackBuild
./etc/
./etc/init.d/
./etc/init.d/nordvpn
./usr/
./usr/bin/
./usr/bin/nordvpn
./usr/lib/
./usr/lib/nordvpn/
./usr/lib/nordvpn/libmoosenordvpnapp.so
./usr/lib/nordvpn/libmooseworker.so
./usr/lib/nordvpn/libnorddrop.so
./usr/lib/nordvpn/libsqlite3.so
./usr/lib/nordvpn/libtelio.so
./usr/lib/nordvpn/nordfileshare
./usr/lib/nordvpn/norduserd
./usr/lib/nordvpn/openvpn
./usr/lib/systemd/
./usr/lib/systemd/system/
./usr/lib/systemd/system/nordvpn.service
./usr/lib/systemd/system/nordvpnd.service
./usr/lib/systemd/system/nordvpnd.socket
./usr/lib/tmpfiles.d/
./usr/lib/tmpfiles.d/nordvpn.conf
./usr/sbin/
./usr/sbin/nordvpnd
./usr/share/
./usr/share/applications/
./usr/share/applications/nordvpn.desktop
./usr/share/bash-completion/
./usr/share/bash-completion/completions/
./usr/share/bash-completion/completions/nordvpn
./usr/share/doc/
./usr/share/doc/nordvpn/
./usr/share/doc/nordvpn/changelog.Debian.gz
./usr/share/icons/
./usr/share/icons/hicolor/
./usr/share/icons/hicolor/scalable/
./usr/share/icons/hicolor/scalable/apps/
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-black.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-blue.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-gray.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn-tray-white.svg
./usr/share/icons/hicolor/scalable/apps/nordvpn.svg
./usr/share/licenses/
./usr/share/licenses/nordvpn/
./usr/share/licenses/nordvpn/LICENSE.md
./usr/share/licenses/nordvpn/THIRD-PARTY-NOTICES.md
./usr/share/man/
./usr/share/man/man1/
./usr/share/man/man1/nordvpn.1.gz
./usr/share/zsh/
./usr/share/zsh/functions/
./usr/share/zsh/functions/Completion/
./usr/share/zsh/functions/Completion/Unix/
./usr/share/zsh/functions/Completion/Unix/_nordvpn_auto_complete
./var/
./var/lib/
./var/lib/nordvpn/
./var/lib/nordvpn/data/
./var/lib/nordvpn/data/countries.dat
./var/lib/nordvpn/data/cybersec.dat
./var/lib/nordvpn/data/insights.dat
./var/lib/nordvpn/data/ovpn_template.xslt
./var/lib/nordvpn/data/ovpn_xor_template.xslt
./var/lib/nordvpn/data/servers.dat

Slackware package maker, version 3.14159265.

Searching for symbolic links:

No symbolic links were found, so we won't make an installation script.
You can make your own later in ./install/doinst.sh and rebuild the
package if you like.

This next step is optional - you can set the directories in your package
to some sane permissions. If any of the directories in your package have
special permissions, then DO NOT reset them here!

Would you like to reset all directory permissions to 755 (drwxr-xr-x) and
directory ownerships to root.root ([y]es, [n]o)? n


Creating Slackware package:  /tmp/SBo/repo.hP4ybd/output_nordvpn/nordvpn-3.19.1-x86_64-1_SBo.txz

./
etc/
etc/rc.d/
etc/rc.d/rc.nordvpn
install/
install/doinst.sh
install/slack-desc
usr/
usr/bin/
usr/bin/nordvpn
usr/doc/
usr/doc/nordvpn-3.19.1/
usr/doc/nordvpn-3.19.1/nordvpn.SlackBuild
usr/lib64/
usr/lib64/nordvpn/
usr/lib64/nordvpn/libmoosenordvpnapp.so
usr/lib64/nordvpn/libmooseworker.so
usr/lib64/nordvpn/libnorddrop.so
usr/lib64/nordvpn/libtelio.so
usr/man/
usr/man/man1/
usr/man/man1/nordvpn.1.gz
usr/sbin/
usr/sbin/nordvpnd
usr/share/
usr/share/applications/
usr/share/applications/nordvpn.desktop
usr/share/bash-completion/
usr/share/bash-completion/completions/
usr/share/bash-completion/completions/nordvpn
usr/share/icons/
usr/share/icons/hicolor/
usr/share/icons/hicolor/scalable/
usr/share/icons/hicolor/scalable/apps/
usr/share/icons/hicolor/scalable/apps/nordvpn-tray-black.svg
usr/share/icons/hicolor/scalable/apps/nordvpn-tray-blue.svg
usr/share/icons/hicolor/scalable/apps/nordvpn-tray-gray.svg
usr/share/icons/hicolor/scalable/apps/nordvpn-tray-white.svg
usr/share/icons/hicolor/scalable/apps/nordvpn.svg
usr/share/licenses/
usr/share/licenses/nordvpn/
usr/share/licenses/nordvpn/LICENSE.md
usr/share/licenses/nordvpn/THIRD-PARTY-NOTICES.md
usr/share/zsh/
usr/share/zsh/functions/
usr/share/zsh/functions/Completion/
usr/share/zsh/functions/Completion/Unix/
usr/share/zsh/functions/Completion/Unix/_nordvpn_auto_complete
var/
var/lib/
var/lib/nordvpn/
var/lib/nordvpn/data/
var/lib/nordvpn/data/countries.dat
var/lib/nordvpn/data/cybersec.dat
var/lib/nordvpn/data/insights.dat
var/lib/nordvpn/data/ovpn_template.xslt
var/lib/nordvpn/data/ovpn_xor_template.xslt
var/lib/nordvpn/data/servers.dat

Slackware package /tmp/SBo/repo.hP4ybd/output_nordvpn/nordvpn-3.19.1-x86_64-1_SBo.txz created.

Built ok:  nordvpn-3.19.1-x86_64-1_SBo.txz                              10:25:57
Testing package nordvpn-3.19.1-x86_64-1_SBo.txz ... 
Test installing nordvpn-3.19.1-x86_64-1_SBo.txz ...
Adding groups and users:
  groupadd -g 373 nordvpn; 
nordvpn-3.19.1-x86_64-1_SBo: Protect your privacy online. .............. [  60M]
Unmounting chroot ... 
Backed up: nordvpn-3.19.0-x86_64-2_SBo.txz
:-) network/nordvpn Updated for version 3.19.1 (-:

sbo-bot · 2024-11-24T10:26:30Z

sbopkglint x86_64 network/nordvpn

Using tests from /usr/share/sbo-maintainer-tools/sbopkglint.d
Exploding /var/lib/repo/SBo/packages/15.0/x86_64/network/nordvpn/nordvpn-3.19.1-x86_64-1_SBo.txz to /tmp/SBo/sbopkglint.TJckFe ...OK
Running pre-doinst test...OK
Installing /var/lib/repo/SBo/packages/15.0/x86_64/network/nordvpn/nordvpn-3.19.1-x86_64-1_SBo.txz to /tmp/SBo/sbopkglint.TJckFe ...OK
Running test: 05-basic-sanity...OK
Running test: 10-docs...OK
Running test: 15-noarch...OK
Running test: 20-arch...
--- ELF binaries/libraries should be executable:
-rw-r--r-- 1 root root 12011112 Nov 24 10:25 usr/lib64/nordvpn/libtelio.so
FAILED
Running test: 25-lafiles...OK
Running test: 30-manpages...OK
Running test: 35-desktop...OK
Running test: 40-newconfig...OK
Running test: 45-doinst...OK
Running test: 50-icons...OK
Running test: 60-usr_info...OK
Running test: 65-python...OK
Running test: 70-tmp_path...OK
Running test: 75-static_libs...OK
Running test: 85-perl...OK
Running test: 90-terminfo...OK
⛔️ !!! nordvpn-3.19.1-x86_64-1_SBo.txz: 1 failures ⛔️

willysr · 2024-11-24T10:44:09Z

@RezaT4795 please review the code for i586

aclemons reviewed Nov 16, 2024

View reviewed changes

willysr reviewed Nov 16, 2024

View reviewed changes

network/nordvpn/nordvpn.SlackBuild Outdated Show resolved Hide resolved

willysr requested changes Nov 16, 2024

View reviewed changes

willysr added the need-rework label Nov 20, 2024

RezaT4795 force-pushed the network/nordvpn branch from d2130db to e2751ba Compare November 23, 2024 21:14

RezaT4795 added 2 commits November 24, 2024 00:50

network/nordvpn: Fixed compatibility issues

c572906

Signed-off-by: Reza Talebi <[email protected]>

network/nordvpn: Fix sbolint error.

bc52885

Signed-off-by: Reza Talebi <[email protected]>

RezaT4795 force-pushed the network/nordvpn branch from e2751ba to bc52885 Compare November 23, 2024 21:20

RezaT4795 added 2 commits November 24, 2024 01:16

network/nordvpn: Fixed hardcoded values.

290007c

Signed-off-by: Reza Talebi <[email protected]>

network/nordvpn: Updated for version 3.19.1.

86f0a8e

Signed-off-by: Reza Talebi <[email protected]>

RezaT4795 requested a review from willysr November 23, 2024 21:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

network/nordvpn: Fixed compatibility issues #8753

network/nordvpn: Fixed compatibility issues #8753

RezaT4795 commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024 •

edited

Loading

aclemons Nov 16, 2024

aclemons Nov 16, 2024

willysr left a comment

noisecode3 commented Nov 18, 2024 •

edited

Loading

willysr commented Nov 20, 2024

RezaT4795 commented Nov 20, 2024

RezaT4795 commented Nov 23, 2024

willysr commented Nov 24, 2024

sbo-bot bot commented Nov 24, 2024

sbo-bot bot commented Nov 24, 2024

sbo-bot bot commented Nov 24, 2024

willysr commented Nov 24, 2024

network/nordvpn: Fixed compatibility issues #8753

Are you sure you want to change the base?

network/nordvpn: Fixed compatibility issues #8753

Conversation

RezaT4795 commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

reverse dependencies - network/nordvpn

github-actions bot commented Nov 15, 2024 • edited Loading

✅ sbolint - network/nordvpn ✅

aclemons Nov 16, 2024

Choose a reason for hiding this comment

aclemons Nov 16, 2024

Choose a reason for hiding this comment

willysr left a comment

Choose a reason for hiding this comment

noisecode3 commented Nov 18, 2024 • edited Loading

willysr commented Nov 20, 2024

RezaT4795 commented Nov 20, 2024

RezaT4795 commented Nov 23, 2024

willysr commented Nov 24, 2024

sbo-bot bot commented Nov 24, 2024

buildpkg i586 network/nordvpn

Snipped Build Failure

sbo-bot bot commented Nov 24, 2024

buildpkg x86_64 network/nordvpn

Snipped Build Log

sbo-bot bot commented Nov 24, 2024

sbopkglint x86_64 network/nordvpn

willysr commented Nov 24, 2024

github-actions bot commented Nov 15, 2024 •

edited

Loading

noisecode3 commented Nov 18, 2024 •

edited

Loading