show error for invalid schema in extraction, text prompt, pdf parser #1696
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add JSON schema validation and type guards for PDFParserNode, TextPromptNode, and extraction nodes in workflow editor. > > - **Error Handling**: > - Add JSON schema validation for `PDFParserNode`, `TextPromptNode`, and extraction nodes in `getWorkflowErrors()` in `workflowEditorUtils.ts`. > - **Type Guards**: > - Add `isPdfParserNode()` and `isTextPromptNode()` functions in `PDFParserNode/types.ts` and `TextPromptNode/types.ts` respectively. > - **Imports**: > - Import `isPdfParserNode` and `isTextPromptNode` in `workflowEditorUtils.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 51f0a774f54bd4739a1c58bb13d4056bbfa3badb. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 79a7f49 in 10 seconds
More details
- Looked at
96lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:1928
- Draft comment:
Consider refactoring the JSON parsing logic into a utility function to reduce redundancy. This logic is repeated for multiple node types (e.g., task, validation, extraction, textPrompt, pdfParser). - Reason this comment was not posted:
Confidence changes required:50%
The JSON parsing logic is repeated multiple times across different node types. This can be refactored into a utility function to improve code maintainability and reduce redundancy.
Workflow ID: wflow_GYzyAPkDjHgADXfS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 79a7f49 in 1 minute and 0 seconds
More details
- Looked at
96lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:1908
- Draft comment:
Consider refactoring the JSON parsing logic into a utility function to avoid repetition and improve maintainability. This applies to lines 1846, 1867, 1872, 1881, 1908, 1917, and 1926. - Reason this comment was not posted:
Confidence changes required:50%
The JSON parsing logic is repeated multiple times across different node types. This can be refactored to a utility function to improve code maintainability and readability.
Workflow ID: wflow_0cGK1Ox9GhQaOyxj
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds JSON schema validation for
extraction,text prompt, andpdf parsernodes, with type guards forPDFParserNodeandTextPromptNode.extraction,text prompt, andpdf parsernodes ingetWorkflowErrors()inworkflowEditorUtils.ts.isPdfParserNode()inPDFParserNode/types.ts.isTextPromptNode()inTextPromptNode/types.ts.This description was created by
for 79a7f49. It will automatically update as commits are pushed.