Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get RESIDENTIAL_DE back which was deleted unexpectedly - frontend #1694

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 31, 2025

Important

Reintroduces ResidentialDE proxy location in ProxyLocation and ProxySelector.

  • Behavior:
    • Reintroduces ResidentialDE in ProxyLocation in types.ts.
    • Adds Residential (Germany) option in ProxySelector in ProxySelector.tsx.

This description was created by Ellipsis for 47a44a7. It will automatically update as commits are pushed.

@wintonzheng wintonzheng merged commit 0da1e38 into main Jan 31, 2025
6 checks passed
@wintonzheng wintonzheng deleted the shu/get_RESIDENTIAL_DE_support_back_p2 branch January 31, 2025 21:29
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 47a44a7 in 8 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/api/types.ts:40
  • Draft comment:
    Ensure that the reintroduced ResidentialDE is used consistently across the codebase where applicable. This includes any logic that might depend on the ProxyLocation values.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR correctly reintroduces the 'ResidentialDE' option in both the types and the component, aligning with the intent to restore a previously deleted option.

Workflow ID: wflow_K3mi3z8fnFHuarZy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant