Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get RESIDENTIAL_DE back which was deleted unexpectedly #1693

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 31, 2025

Important

Re-add RESIDENTIAL_DE to ProxyLocation enum and update get_tzinfo_from_proxy() to handle it in tasks.py.

  • Enums:
    • Re-add RESIDENTIAL_DE to ProxyLocation enum in tasks.py.
  • Functions:
    • Update get_tzinfo_from_proxy() in tasks.py to return ZoneInfo("Europe/Berlin") for RESIDENTIAL_DE.

This description was created by Ellipsis for d8f9422. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d8f9422 in 13 seconds

More details
  • Looked at 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/tasks.py:67
  • Draft comment:
    The timezone for RESIDENTIAL_JP was incorrectly set to Asia/Kolkata. This PR correctly changes it to Asia/Tokyo. Ensure this change is intentional and correct.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_N7Vg4zrKLIGRBE8t


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 588be81 into main Jan 31, 2025
7 checks passed
@wintonzheng wintonzheng deleted the shu/get_RESIDENTIAL_DE_support_back branch January 31, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant