-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actionability parameter to the rule baseclass. #243
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field property
for this new value is missing
@@ -15,6 +15,7 @@ | |||
|
|||
|
|||
class Rule(ABC): | |||
ACTIONABILITY = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rename the field to: ACTIONABLE instead of ACTIONABILITY
Since it'll be either actionable or non-actionable. Actionability sounds "weird"
ACTIONABILITY = True | |
ACTIONABLE = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to include the new property in the config or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure of it when I added my other comment. Now that I think of it, we can safe proof it, and add it to the config with the same value. This way, if some user/dependency of cfripper needs to override the value, it can be done safely in their config 👍
Maybe it'd be worth to add something a bit more extensible. We could add a variable called |
We add an actionability parameter to the base class rule. If
True
, this parameter indicates that the non-fulfilment of the rule can be solved without recreating any resource and/or stack. The standard value is set toTrue
for all rules.