Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Qt and CI script versions, fix macOS support, and drop support for qmake #98

Merged
merged 32 commits into from
May 20, 2024

Conversation

Cuperino
Copy link
Contributor

Bumping the Qt acquisition script should fix build errors in CI.

@Cuperino
Copy link
Contributor Author

I've bumped the versions to the latest micro versions available. Nevertheless, the Qt 5s fail to build, with linker undefined symbol errors that occur after bumping jurplel/install-qt-action.

@Shatur
Copy link
Collaborator

Shatur commented Apr 25, 2024

Looks like on MacOS it tries to build it for ARM, but Qt binaries are for x86.

Cuperino added 3 commits May 19, 2024 17:43
QMake is on its way out. This should give projects one more reason to move over to CMake.
@Cuperino Cuperino changed the title Bump Qt versions and Qt acquisition script Bump Qt and CI script versions, fix macOS support, and drop support for qmake May 19, 2024
@Cuperino
Copy link
Contributor Author

@Shatur I got CI fixed for all systems using CMake. I couldn't get the qmake build to work with Windows, I don't normally work on Windows and QMake is being phased out anyways, so I opted to remove those builds from CI in the end.

Feel free to re-add them and fix whatever issue is left. Here is the commit that got the closest to getting qmake to work everywhere: 57525e0

@Shatur
Copy link
Collaborator

Shatur commented May 20, 2024

I'm on board with removing qmake. Could you remove the qmake file completely?

@Cuperino
Copy link
Contributor Author

Done. All files pertaining qmake have been removed.

@Shatur Shatur merged commit b519155 into Skycoder42:master May 20, 2024
9 checks passed
@Shatur
Copy link
Collaborator

Shatur commented May 20, 2024

Thank you!

@Cuperino Cuperino deleted the patch-1 branch May 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants